Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect routing when the query parameter is in the configuration #2064

Closed
Burgyn opened this issue May 10, 2024 · 0 comments · Fixed by #2225
Closed

Incorrect routing when the query parameter is in the configuration #2064

Burgyn opened this issue May 10, 2024 · 0 comments · Fixed by #2225
Labels
merged Issue has been merged to dev and is waiting for the next release NET9 .NET 9 release
Milestone

Comments

@Burgyn
Copy link

Burgyn commented May 10, 2024

Hi guys.

I discovered strange and different routing behavior between versions 22.0.1 and 23.0.0.

Expected Behavior

In version 22.0.1 the routing works well as expected.
We have the following configuration:

{
    "DownstreamPathTemplate": "/{tenantId}/products?{everything}",
    "UpstreamPathTemplate": "/{tenantId}/products?{everything}",
    "UpstreamHttpMethod": [ "Get" ]
},
{
    "DownstreamPathTemplate": "/{tenantId}/products/{everything}",
    "UpstreamPathTemplate": "/{tenantId}/products/{everything}",
    "UpstreamHttpMethod": [ "Get" ]
},

When I call a request

GET localhost/1/products/1

then the correct route "/{tenantId}/products/{everything}" is selected.

Actual Behavior

In version 23.0.0 the "DownstreamPathTemplate":"/{tenantId}/products?{everything}" path is chosen for some reason, which is not correct.

Specifications

  • Version: >23.0.0

Maybe this PR? #748

Any idea for a quick fix on my part?
Thank you very much.

@ThreeMammals ThreeMammals locked and limited conversation to collaborators May 10, 2024
@raman-m raman-m converted this issue into discussion #2065 May 10, 2024
@raman-m raman-m added the NET9 .NET 9 release label Dec 10, 2024
@raman-m raman-m added this to the .NET 9 milestone Dec 10, 2024
@raman-m raman-m moved this from Todo to In Progress in Mentoring Finn Fiedler Dec 10, 2024
@raman-m raman-m moved this from In Progress to Done in Mentoring Finn Fiedler Dec 10, 2024
@raman-m raman-m added the merged Issue has been merged to dev and is waiting for the next release label Dec 13, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
merged Issue has been merged to dev and is waiting for the next release NET9 .NET 9 release
Projects
Status: Done
2 participants