There is a repeated section of code in the source code. Although it does not affect the function, it is not elegant.

[MingWangSong]

In lines 13 to 23 of source code ./mgmtd/source/net/message/nodes/storagepools/AddStoragePoolMsgEx.cpp, the ShuttingDown judgment for APP is repeated. I hope it can be fixed in the next version update. Thank you. The source code is as follows：

bool AddStoragePoolMsgEx::processIncoming(ResponseContext& ctx)
{
   StoragePoolStore* storagePoolStore = Program::getApp()->getStoragePoolStore();

   if (Program::getApp()->isShuttingDown())
   {
      ctx.sendResponse(GenericResponseMsg(GenericRespMsgCode_TRYAGAIN, "Mgmtd shutting down."));
      return true;
   }

   if (Program::getApp()->isShuttingDown())
   {
      ctx.sendResponse(GenericResponseMsg(GenericRespMsgCode_TRYAGAIN, "Mgmtd shutting down."));
      return true;
   }
........
}

[iamjoemccormick]

Hi @MingWangSong,

I can't promise it will be merged in time, but I submitted a pull request dropping the duplicate block as you're correct it is unneeded. Thanks for the report!