Skip to content

Commit

Permalink
Feature: Relocate Node.js installation lesson (#4870)
Browse files Browse the repository at this point in the history
<!-- Thank you for taking the time to contribute to The Odin Project. In
order to get this pull request (PR) merged in a reasonable amount of
time, you must complete this entire template. -->

## Because
<!-- Summarize the purpose or reasons for this PR, e.g. what problem it
solves or what benefit it provides. -->
we are replacing Replit exercises with ones from `javascript-exercises`,
so we need to do set up for Node.js earlier in the JavaScripts Basics
course.

## This PR
<!-- A bullet point list of one or more items describing the specific
changes. -->
* Moves the Installing Node.js lesson so it is right before the Data
Types and Conditionals lesson
- The Data Types and Conditionals lesson is where we will have new
material from `javascript-exercises`

## Issue
<!--
If this PR closes an open issue in this repo, replace the XXXXX below
with the issue number, e.g. Closes #2013.

If this PR closes an open issue in another TOP repo, replace the #XXXXX
with the URL of the issue, e.g. Closes
https://github.com/TheOdinProject/curriculum/issues/XXXXX

If this PR does not close, but is related to another issue or PR, you
can link it as above without the 'Closes' keyword, e.g. 'Related to
#2013'.
-->
Related to TheOdinProject/curriculum#29054

## Additional Information
<!-- Any other information about this PR, such as a link to a Discord
discussion. -->
Since multiple repos are affected simultaneously, it may be ideal to
merge all 3 PRs at once:

**Blockers:**
* Need to add the four new exercises to the `javascript-exercises` repo
- TheOdinProject/javascript-exercises#509
* Need to update the appropriate lessons within our `curriculum` repo to
replace the Replit lessons currently there -
TheOdinProject/curriculum#29161

I will link the relevant PRs here in a moment after I create them.

## Pull Request Requirements
<!-- Replace the whitespace between the square brackets with an 'x',
e.g. [x]. After you create the PR, they will become checkboxes that you
can click on. -->
- [x] I have thoroughly read and understand [The Odin Project
Contributing
Guide](https://github.com/TheOdinProject/theodinproject/blob/main/CONTRIBUTING.md)
- [x] The title of this PR follows the `keyword: brief description of
change` format, using one of the following keywords:
    - `Feature` - adds new or amends existing user-facing behavior
- `Chore` - changes that have no user-facing value, refactors,
dependency bumps, etc
    - `Fix` - bug fixes
-   [x] The `Because` section summarizes the reason for this PR
- [x] The `This PR` section has a bullet point list describing the
changes in this PR
- [ ] I have verified all tests and linters pass after making these
changes.
- [x] If this PR addresses an open issue, it is linked in the `Issue`
section
-   [ ] If applicable, this PR includes new or updated automated tests
  • Loading branch information
Eduardo06sp authored Dec 10, 2024
1 parent 8175df7 commit efc8a99
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion db/fixtures/paths/foundations/seed.rb
Original file line number Diff line number Diff line change
Expand Up @@ -136,14 +136,14 @@

section.add_lessons(
foundation_lessons.fetch('Variables and Operators'),
foundation_lessons.fetch('Installing Node.js'),
foundation_lessons.fetch('Data Types and Conditionals'),
foundation_lessons.fetch('JavaScript Developer Tools'),
foundation_lessons.fetch('Function Basics'),
foundation_lessons.fetch('Problem Solving'),
foundation_lessons.fetch('Understanding Errors'),
foundation_lessons.fetch('Rock Paper Scissors'),
foundation_lessons.fetch('Clean Code'),
foundation_lessons.fetch('Installing Node.js'),
foundation_lessons.fetch('Arrays and Loops'),
foundation_lessons.fetch('DOM Manipulation and Events'),
foundation_lessons.fetch('Revisiting Rock Paper Scissors'),
Expand Down

0 comments on commit efc8a99

Please sign in to comment.