Skip to content

Conversation

henrylin03
Copy link
Contributor

Because

The current example image for showing styles applied and overwritten styles is outdated and don't correspond to the current TOP code in the inspector...

This PR

Uploads the updated image to the repository. Per guidance (https://github.com/TheOdinProject/curriculum/wiki/Adding-Images-to-the-Curriculum), this is the first of two PRs required to make this update, as we are uploading image. IIUC, this PR needs to be merged first before I can create static link.

Issue

Relates to #29968

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

…spector.

this relates to TheOdinProject#29968. Per guidance on adding images to Curriculum (https://github.com/TheOdinProject/curriculum/wiki/Adding-Images-to-the-Curriculum), this is the first of two PRs I need to raise for TheOdinProject#29968.
Copy link
Contributor

@mao-sz mao-sz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things:

  1. We need both images replaced (showing the Elements view, and showing the Styles stuff), not just the styles stuff.

  2. We need them to replace the current images, so the first image should be named 01.png to replace the existing one, the second image named 02.png, and the existing 03.png gets deleted. This won't affect the current lesson contents because those get images from a CDN, not the repo.

  3. The new image doesn't show what I see in the styles pane when inspecting the <h1> itself (in Chrome). This is what I see:

    image

@henrylin03
Copy link
Contributor Author

henrylin03 commented Sep 14, 2025

Thanks @mao-sz - will address this today, but just wanted to let you know what's happening

  1. We need both images replaced (showing the Elements view, and showing the Styles stuff), not just the styles stuff.

No worries, I'll use the image you shared in your point 3.

  1. We need them to replace the current images, so the first image should be named 01.png to replace the existing one, the second image named 02.png, and the existing 03.png gets deleted. This won't affect the current lesson contents because those get images from a CDN, not the repo.

Can do. Just checking though, step 4 of this is saying we should start from 00.png not 01.png - should I do that instead?

  1. The new image doesn't show what I see in the styles pane when inspecting the <h1> itself (in Chrome). This is what I see:
    image

Not sure why the discrepancy, but I'll use your image and annotate it

I'll ask for reapproval when ready, but lmk if I've misunderstood. After this, I'll put in that 2nd PR to create static links per docs.

Thanks!

…ng: (1) Elements view and (2) styles being overriden. add comments to alert that images in the page will eventually be replaced.

the images will only be replaced in the code (and thus on the site) once TheOdinProject#30119 has been merged and I can then generate the static link on CDN
@henrylin03 henrylin03 requested a review from mao-sz September 14, 2025 04:10
Copy link
Contributor

@mao-sz mao-sz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @henrylin03, though both images are quite blurry to me, especially the one showing the styles pane. While it's still clear what's being pointed to, I'd prefer if the image was a little sharper at least.

Edit: ah, probably if you're cropping my image then GitHub's compressed it loads?
With your original image, what OS and browser (+ version) were you using? And what element had you inspected to see those styles? Because when you inspect the h1 itself, you don't get the styles shown in your original image, nor do I get them from either of the inner spans.

Comment on lines +23 to +28
<!-- to be replaced by 00.png -->
![Inspector Icon](https://cdn.statically.io/gh/TheOdinProject/curriculum/594984d7c9f9e744577f19ea475b3864e8cc7c91/html_css/v2/foundations/inspecting-html-and-css/imgs/01.png)

<span id="strikethrough">When an element is selected, the Styles tab will show all the currently applied styles, as well as any styles that are being overwritten (indicated by a strikethrough of the text).</span> For example, if you use the inspector to click on the "Your Career in Web Development Starts Here" header on the [TOP homepage](https://www.theodinproject.com/home), on the right-hand side you'll see all the styles that are currently affecting the element, as seen below:

<!-- to be replaced by 01.png -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need the comments here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Foundations Involves the Foundations content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants