Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoR forms project - Update CSRF token related sections #29165

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jg-k
Copy link

@jg-k jg-k commented Dec 8, 2024

Because

Turbo is enabled by default from Rails 7 but tasks related to CSRF token in the first rails form project do not take into account default form behavior with Turbo.

This PR

  • Extends the tasks of the rails form project by getting the student to submit the manually created form without then with turbo enabled to provide a better understanding of which CSRF token is needed where.
  • Removes the paragraph explaining how to add a hidden input with a CSRF token from the lesson and relocates it to the project section. This avoids introducing too much details related to Turbo in the lesson, as it would extend beyond the core topic of the lesson. It is proposed to address the impact of Turbo more comprehensively separately.

Issue

Closes #28932

Additional Information

NA

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Ruby on Rails Involves the Ruby on Rails course label Dec 8, 2024
@jg-k jg-k changed the title RoR forms project - Update CSRF related sections RoR forms project - Update CSRF token related sections Dec 8, 2024
@wise-king-sullyman wise-king-sullyman requested review from a team and rlmoser99 and removed request for a team December 10, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Ruby on Rails Involves the Ruby on Rails course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails: update first form project description to account for default form submission behavior with Turbo
1 participant