Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS and Ruby On Rails CS Section: Add new image for knights travails #26236

Merged
merged 4 commits into from
Aug 29, 2023
Merged

JS and Ruby On Rails CS Section: Add new image for knights travails #26236

merged 4 commits into from
Aug 29, 2023

Conversation

Ruchita1010
Copy link
Contributor

Because

Improved image of the chessboard for knights travails

This PR

Adds statically CDN link for the uploaded images(chessboard) in #26217

Issue

Closes #26006

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added Content: JavaScript Involves the JavaScript course Content: Ruby Involves the Ruby course labels Aug 28, 2023
KevinMulhern
KevinMulhern approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Ruchita1010

@KevinMulhern KevinMulhern merged commit 87c5bfc into TheOdinProject:main Aug 29, 2023
2 checks passed
@Ruchita1010 Ruchita1010 deleted the knights_travails_update branch August 29, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinMulhern KevinMulhern KevinMulhern approved these changes

Assignees
No one assigned
Labels
Content: JavaScript Involves the JavaScript course Content: Ruby Involves the Ruby course
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CS Section: Knights Travails update examples
2 participants
@Ruchita1010 @KevinMulhern