-
Notifications
You must be signed in to change notification settings - Fork 77.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discrepancy Between solution.html and desired-outcome.png in 01-css-methods #660
Comments
The exercise's README.md states the following:
So depending on the browser (which should be Chrome if following TOP's instructions), fonts set in the browser, screen scaling etc., there may be subtle differences from the screenshot. They don't matter, only that the actual instructions have been followed. On my Linux machine using Chrome, the solution produces an almost identical outcome for me, only minute differences due to different fonts I've set in my browser. Using different browsers, some lead to even more different default styles applied (hence TOP recommending the use of and only supporting Chrome). Changing the solution HTML to your proposal will go against the instructions which specify only that an orange background and 18px font are set via an inline style for that button. |
I was using chrome too though so it seemed strange to me to see a difference both in color and style and thought maybe the code was wrong. |
Border Color: Instead of border-color: white;, try border: 2px solid white; to ensure visibility. Since padding isn't introduced yet, you might be limited, but if allowed, add: If a stylesheet is linked, ensure the button class (if used) has the correct styles. Sometimes other CSS rules may override the inline styles. Check if any .css files are affecting the button. |
Description:
The current implementation of
solution.html
does not visually align with the reference imagedesired-outcome.png
. Specifically, the button's styling differs from the expected design.Steps to Reproduce:
foundations/intro-to-css/01-css-methods/solution/solution.html
.solution.html
in a web browser.desired-outcome.png
.Expected Behavior (Desired Outcome):
The button should have:
desired-outcome.png
.Actual Behavior:
The button currently displays:
desired-outcome.png
.Suggested Fix:
To align the button's appearance with the desired outcome, replace the button in
solution.html
with the following (Ignoring padding which hasn't been introduced in the course at this point and should probably be modified in the image):The text was updated successfully, but these errors were encountered: