Update executingSystemCommands.py

Author: TheM1ddleM1n

system/executingSystemCommands.py

@@ -1,59 +1,53 @@
 import subprocess
 import os
 import shlex
+import logging
 
+logging.basicConfig(level=logging.INFO, format="%(levelname)s: %(message)s")
 
-# 1. Using subprocess.run (Recommended for most use cases)
-def run_with_subprocess_run(command):
+def run_with_subprocess_run(command, timeout=10):
     try:
         result = subprocess.run(
-            command, shell=True, check=True, text=True, capture_output=True
+            shlex.split(command), check=True, text=True, capture_output=True, timeout=timeout
         )
-        print("Output:", result.stdout)
+        logging.info("Output: %s", result.stdout.strip())
+    except subprocess.TimeoutExpired:
+        logging.error("Command timed out after %d seconds", timeout)
     except subprocess.CalledProcessError as e:
-        print("Error:", e.stderr)
+        logging.error("Error: %s", e.stderr.strip())
 
-
-# 2. Using subprocess.Popen (More control over input/output streams)
-def run_with_subprocess_popen(command):
+def run_with_subprocess_popen(command, timeout=10):
     process = subprocess.Popen(
         shlex.split(command), stdout=subprocess.PIPE, stderr=subprocess.PIPE, text=True
     )
-    stdout, stderr = process.communicate()
-    if process.returncode == 0:
-        print("Output:", stdout)
-    else:
-        print("Error:", stderr)
-
-
-# 3. Using os.system (Simple but not recommended for new code due to security risks)
-def run_with_os_system(command):
-    exit_code = os.system(command)
-    print(f"Command exited with code {exit_code}")
-
-
-# 4. Using subprocess.check_output (Useful for capturing command output)
-def run_with_check_output(command):
     try:
-        output = subprocess.check_output(command, shell=True, text=True)
-        print("Output:", output)
+        stdout, stderr = process.communicate(timeout=timeout)
+        if process.returncode == 0:
+            logging.info("Output: %s", stdout.strip())
+        else:
+            logging.error("Error: %s", stderr.strip())
+    except subprocess.TimeoutExpired:
+        process.kill()
+        stdout, stderr = process.communicate()
+        logging.error("Command timed out and process was killed")
+
+def run_with_check_output(command, timeout=10):
+    try:
+        output = subprocess.check_output(shlex.split(command), text=True, timeout=timeout)
+        logging.info("Output: %s", output.strip())
+    except subprocess.TimeoutExpired:
+        logging.error("Command timed out after %d seconds", timeout)
     except subprocess.CalledProcessError as e:
-        print("Error:", e.stderr)
+        logging.error("Error: %s", e.stderr.strip())
 
-
-# Example commands for demonstration
 command1 = "echo Hello, World!"
 command2 = "ls -l" if os.name != "nt" else "dir"
 
-# Execute the commands using various methods
-print("=== subprocess.run ===")
+logging.info("=== subprocess.run ===")
 run_with_subprocess_run(command1)
 
-print("\n=== subprocess.Popen ===")
+logging.info("=== subprocess.Popen ===")
 run_with_subprocess_popen(command1)
 
-print("\n=== os.system ===")
-run_with_os_system(command1)
-
-print("\n=== subprocess.check_output ===")
+logging.info("=== subprocess.check_output ===")
 run_with_check_output(command1)