Skip to content

Commit 206a10b

Browse files
author
Andrey Helldar
committed
Bump andrey-helldar/support to 4.0 version
1 parent 9fc6d50 commit 206a10b

File tree

4 files changed

+14
-13
lines changed

4 files changed

+14
-13
lines changed

.github/workflows/phpunit.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
matrix:
1111
php: [ "7.2", "7.3", "7.4" ]
1212
laravel: [ "5.4.*" ]
13-
support: [ "2.0", "3.0" ]
13+
support: [ "4.0" ]
1414
laravel_support: [ "1.3", "2.0" ]
1515

1616
name: Laravel ${{ matrix.laravel }}, PHP ${{ matrix.php }}, Support ${{ matrix.support }}, Laravel Support ${{ matrix.laravel_support }}
@@ -45,7 +45,7 @@ jobs:
4545
matrix:
4646
php: [ "7.2", "7.3", "7.4" ]
4747
laravel: [ "5.5.*" ]
48-
support: [ "2.0", "3.0" ]
48+
support: [ "4.0" ]
4949
laravel_support: [ "1.3", "2.0" ]
5050

5151
name: Laravel ${{ matrix.laravel }}, PHP ${{ matrix.php }}, Support ${{ matrix.support }}, Laravel Support ${{ matrix.laravel_support }}
@@ -80,7 +80,7 @@ jobs:
8080
matrix:
8181
php: [ "7.2", "7.3", "7.4" ]
8282
laravel: [ "5.6.*" ]
83-
support: [ "2.0", "3.0" ]
83+
support: [ "4.0" ]
8484
laravel_support: [ "1.3", "2.0" ]
8585

8686
name: Laravel ${{ matrix.laravel }}, PHP ${{ matrix.php }}, Support ${{ matrix.support }}, Laravel Support ${{ matrix.laravel_support }}
@@ -115,7 +115,7 @@ jobs:
115115
matrix:
116116
php: [ "7.2", "7.3", "7.4" ]
117117
laravel: [ "5.7.*" ]
118-
support: [ "2.0", "3.0" ]
118+
support: [ "4.0" ]
119119
laravel_support: [ "1.3", "2.0" ]
120120

121121
name: Laravel ${{ matrix.laravel }}, PHP ${{ matrix.php }}, Support ${{ matrix.support }}, Laravel Support ${{ matrix.laravel_support }}
@@ -150,7 +150,7 @@ jobs:
150150
matrix:
151151
php: [ "7.2", "7.3", "7.4" ]
152152
laravel: [ "5.8.*" ]
153-
support: [ "2.0", "3.0" ]
153+
support: [ "4.0" ]
154154
laravel_support: [ "1.3", "2.0" ]
155155

156156
name: Laravel ${{ matrix.laravel }}, PHP ${{ matrix.php }}, Support ${{ matrix.support }}, Laravel Support ${{ matrix.laravel_support }}
@@ -185,7 +185,7 @@ jobs:
185185
matrix:
186186
php: [ "7.2", "7.3", "7.4", "8.0" ]
187187
laravel: [ "^6.0" ]
188-
support: [ "2.0", "3.0" ]
188+
support: [ "4.0" ]
189189
laravel_support: [ "1.3", "2.0" ]
190190

191191
name: Laravel ${{ matrix.laravel }}, PHP ${{ matrix.php }}, Support ${{ matrix.support }}, Laravel Support ${{ matrix.laravel_support }}
@@ -220,7 +220,7 @@ jobs:
220220
matrix:
221221
php: [ "7.2", "7.3", "7.4", "8.0" ]
222222
laravel: [ "^7.0" ]
223-
support: [ "2.0", "3.0" ]
223+
support: [ "4.0" ]
224224
laravel_support: [ "1.3", "2.0" ]
225225

226226
name: Laravel ${{ matrix.laravel }}, PHP ${{ matrix.php }}, Support ${{ matrix.support }}, Laravel Support ${{ matrix.laravel_support }}
@@ -255,7 +255,7 @@ jobs:
255255
matrix:
256256
php: [ "7.3", "7.4", "8.0" ]
257257
laravel: [ "^8.0" ]
258-
support: [ "2.0", "3.0" ]
258+
support: [ "4.0" ]
259259
laravel_support: [ "1.3", "2.0" ]
260260

261261
name: Laravel ${{ matrix.laravel }}, PHP ${{ matrix.php }}, Support ${{ matrix.support }}, Laravel Support ${{ matrix.laravel_support }}

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"require": {
1818
"php": "^7.2.5|^8.0",
1919
"andrey-helldar/laravel-support": "^1.3.2|^2.0",
20-
"andrey-helldar/support": "^2.0|^3.0",
20+
"andrey-helldar/support": "^4.0",
2121
"illuminate/routing": "^5.0|^6.0|^7.0|^8.0",
2222
"illuminate/support": "^5.0|^6.0|^7.0|^8.0",
2323
"phpdocumentor/reflection-docblock": "^5.0"

src/Models/Route.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
use Helldar\LaravelRoutesCore\Facades\Annotation;
66
use Helldar\LaravelSupport\Facades\App;
77
use Helldar\Support\Facades\Helpers\Arr as ArrHelper;
8-
use Helldar\Support\Facades\Helpers\Http;
8+
use Helldar\Support\Facades\Http\Builder;
9+
use Helldar\Support\Facades\Http\Url;
910
use Illuminate\Contracts\Support\Arrayable;
1011
use Illuminate\Routing\Route as IlluminateRoute;
1112
use Illuminate\Support\Arr;
@@ -102,8 +103,8 @@ public function getDomain(): ?string
102103
return $domain;
103104
}
104105

105-
return $this->domain_force
106-
? Http::domain($this->url)
106+
return $this->domain_force && Url::is($this->url)
107+
? Builder::parse($this->url)->getDomain()
107108
: null;
108109
}
109110

tests/Fixtures/Config.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public function getHideMatching(): array
2828

2929
public function getDomainForce(): bool
3030
{
31-
return false;
31+
return true;
3232
}
3333

3434
public function getUrl(): ?string

0 commit comments

Comments
 (0)