Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Insertion sort, palindrome code as well as Subset generator code #88

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Added Insertion sort, palindrome code as well as Subset generator code #88

merged 4 commits into from
Oct 27, 2023

Conversation

Yash9276
Copy link
Contributor

@Yash9276 Yash9276 commented Oct 4, 2023

Added Insertion sort, palindrome code, and Subset generator code with appropriate comments .
Kindly review the PR and merge it.
Thank you :)

@Yash9276 Yash9276 requested a review from mkubdev as a code owner October 4, 2023 20:13
mkubdev
mkubdev requested changes Oct 26, 2023
View reviewed changes
Copy link
Member

@mkubdev mkubdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello 👋

Please add the missing bracket, otherwise LGTM.
Thanks for your contribution. Implementations are clear, it's great that you've included comments to explain the purpose and logic.

src/Maths/Palindrome.sol Outdated Show resolved Hide resolved
@mkubdev mkubdev merged commit 08cba51 into TheAlgorithms:main Oct 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkubdev mkubdev mkubdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yash9276 @mkubdev @Yash2934