Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Possible underflow in binary search #85

Closed
Vikram710 opened this issue Jul 24, 2023 · 2 comments · Fixed by #86
Closed

[BUG] Possible underflow in binary search #85

Vikram710 opened this issue Jul 24, 2023 · 2 comments · Fixed by #86
Assignees
@Adi9876
Labels
bug Something isn't working

Comments

@Vikram710
Copy link

Vikram710 commented Jul 24, 2023 •
edited
Loading

Possible underflow in binary search here

example input arr = {2} target = 1

middle will be 0
maximum = middle - 1; 0 -1
0x11: If an arithmetic operation results in underflow or overflow outside of an unchecked { ... } block.
@Panquesito7 Panquesito7 added the bug Something isn't working label Jul 25, 2023
@Adi9876
Copy link
Contributor

Adi9876 commented Oct 1, 2023

@Panquesito7 assign me this task i can fix it !!

@Adi9876
Copy link
Contributor

Adi9876 commented Oct 2, 2023 •
edited
Loading

@mkubdev @Panquesito7 can you please check my updated code also verify the pull request that i made !! FIXED THE BUG !!

@Panquesito7 Panquesito7 linked a pull request Oct 4, 2023 that will close this issue
Fixed the underFlow bug in src/binarySearch.sol #86
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adi9876 Adi9876

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed the underFlow bug in src/binarySearch.sol Adi9876/Solidity
3 participants
@Vikram710 @Panquesito7 @Adi9876