Commiting to a fork of this repo on a mac or linux does not work (using git)

[XenoBytesX]

What would you like to share?

Commiting to a fork of this repo on a mac or linux using git cli does not work because of pre-commit

In scripts/validate_files.py, the first line is:-
#!python

When pre-commit runs the validate_files hook, it uses python but python is there on windows.
On macos and linux, its python3. I also tried using alias python = python3 but it still does not work

Additional information

No response

[joey-the-33rd]

Bug Report

Title: pre-commit hook validate_files.py fails on macOS/Linux due to incorrect Python interpreter

Description:

The pre-commit hook validate_files.py located in the scripts/ directory fails when committing changes on macOS and Linux systems. This is because the shebang line #!/usr/bin/env python in the script forces the use of python, which often points to Python 2 on these systems. Python 2 is not guaranteed to be present, and the script may not be compatible with it. Aliasing python to python3 does not resolve the issue as the shebang line explicitly calls python.

Steps to Reproduce:

1. Set up a fork of the repository on a macOS or Linux system.
2. Install pre-commit.
3. Attempt to commit any changes.
4. The validate_files hook will fail, displaying an error related to Python 2 not being found or the script not being compatible with Python 2.

Expected Result:

The validate_files hook should execute successfully using Python 3 on macOS and Linux systems.

Actual Result:

The validate_files hook fails due to the incorrect Python interpreter being called.

Possible cause:

The shebang line #!/usr/bin/env python in scripts/validate_files.py forces the use of python which often defaults to Python 2 on macOS/Linux.

Proposed Solution:

Modify the shebang line in scripts/validate_files.py to use #!/usr/bin/env python3 to explicitly call Python 3, or use #!/usr/bin/env python and ensure the script is compatible with both Python 2 and Python 3. Ideally, the first option is preferred.

Environment:

• Operating Systems: macOS, Linux
• pre-commit version: (Please specify the version used)
• Git version: (Please specify the version used)

Additional Information:

• The issue does not occur on Windows systems where python is more likely to refer to a Python 3 installation.
• Attempting to alias python to python3 in the shell does not resolve the issue.

[XenoBytesX]

If we change the shebang to python3 instead of python then it would stop working for windows