Build Agreement Integration Test Suite

[Kalchaqui]

Agreement Integration Test Suite (corrected endpoints)

Depends on: #61 (for activity assertions)

Task Description

Add/extend integration tests for the Agreements module. A Jest setup already exists (jest.config.js, src/integration/migrated-flows.integration.spec.ts, plus module .spec.ts files), so this builds on the existing suite rather than starting new. The goal is trustworthy coverage of the real endpoints and their error paths.

Background / Current State

• The original test issue referenced GET /agreements, which does not exist — the real route is GET /agreements/by-wallet.
• PATCH /agreements/:id/link-contract was missing from the original list and must be covered.

Deliverable

An integration test suite covering the real Agreements endpoints and their error paths.

Requirements

Test the actual endpoints (corrected against the current controller):

Endpoint	Method
/agreements	POST
/agreements/by-wallet?wallet=	GET (not GET /agreements)
/agreements/:id	GET
/agreements/:id/link-contract	PATCH (was missing originally)
/agreements/:id/status	PATCH
/agreements/:id/milestones	PATCH
/agreements/:id/activity	GET
/agreements/by-contract/:contractId	GET

• Happy path + error path for each (invalid token, not found, unauthorized wallet).
• Assert activity entries are created on status/milestone changes (depends on Issue A).

Validation System

• All tests pass in CI (pnpm test) before merge.
• Each endpoint has at least one success and one failure case.

Technical Requirements

• Reuse the existing Jest config and Supabase mock utilities already in the repo.
• Use a test JWT/wallet fixture.
• Do not introduce a parallel test harness — extend the current suite.

Additional Notes

The corrected endpoint list is the key value here: the original issue would have produced tests against a non-existent GET /agreements route. This issue fixes that and adds link-contract.

Testing (required)

• Success + failure case implemented for each endpoint in the table.
• Activity assertions verify entries are created on status/milestone changes.
• Suite runs green in CI via pnpm test.

Proof of Completion (required)

• Link the merged PR.
• Paste the passing CI pnpm test output showing the Agreements suite.
• Confirm (link/diff) the tests target GET /agreements/by-wallet and include PATCH /agreements/:id/link-contract.

[Richardkingz2019]

Hi maintainer, i have been a practicing web dev for over a year now with a lot of experiencing working full stack projects and i have studied this issue description titled Build Agreement Integration Test Suite
#62 and i understood what is need to be done , the task description, requirements and the acceptable criteria. I shall deliver on this within 24 hours with detailed and qualitaive PR rendition. I shall be grateful if this opportunity to work on this issue is given. Thank You

[ayomideadeniran]

Hi, I’d like to work on this issue.
I understand that the main goal is to create integration tests that cover the complete Agreement flow and make sure future changes do not break existing functionality.
My approach will be to first check the current project test setup and how Agreements, authentication, and permissions are handled. Then I’ll write tests for creating, fetching, updating status and milestones, activity history, contract-based retrieval, invalid inputs, permission checks, and error cases.
I’ll make sure the tests are clean, reusable, and can run in the CI pipeline. I’ll also check the listed endpoints carefully and point out any missing or unclear update route before starting.
I can complete this within 2–3 days. Please assign it to me.

[grantfox-oss]

🦊 GrantFox — @ayomideadeniran has been assigned to this issue as part of the Official Campaign | FWC26 campaign!

Next steps:

1. Open a Pull Request referencing this issue (e.g., Closes #62)
2. Your PR will be reviewed by the Thalos-Infrastructure maintainers

Good luck! Track your progress on GrantFox.

[ManuelJG1999]

🎉 Congratulations @ayomideadeniran ! This issue has been assigned to you.

Before you start, make sure you understand the requirements. If you have any questions, ask us in our community chat:
https://t.me/ThalosOSSCommunity

Please keep us updated on your progress. If there's no activity or communication within 48 hours, the issue may be reassigned to another contributor.

Happy coding, and thanks for contributing to Thalos! 🐉

[grantfox-oss]

🎉 This issue has been marked as completed on GrantFox as part of the Official Campaign | FWC26 campaign!

@ayomideadeniran's PR #102 was approved and merged by @Kalchaqui.

🏆 @ayomideadeniran: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (659 total points). Track your full progress on GrantFox.

👏 Great work, @ayomideadeniran! Keep contributing to Thalos-Infrastructure.