Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Download manifest.json from the release, not from HEAD #81

Open
RyotaUshio opened this issue Feb 28, 2024 · 0 comments
Open

[FR] Download manifest.json from the release, not from HEAD #81

RyotaUshio opened this issue Feb 28, 2024 · 0 comments

Comments

@RyotaUshio
Copy link
Contributor

RyotaUshio commented Feb 28, 2024

Hi, yesterday my plugin PDF++ was approved by the Obsidian team and made available in the official plugin browser, then I've noticed that the official download count (about 600) of my plugin is significantly lower than the number of downloads made via BRAT (over 4000).

I counted BRAT downloads by this script: https://forum.obsidian.md/t/plotting-download-counts-of-my-github-project-using-obsidian-charts-and-dataviewjs/67411
It sums up the download_counts of main.js for all releases.

On the other hand, Obsidian's official download count is the total number of downloads of manifest.json from all releases.
https://github.com/obsidianmd/obsidian-releases/blob/master/.github/workflows/plugin-stat.yml

So here's the problem: BRAT seems to download manifest.json from the repository, not from the release, and this leads to a significant underestimation of downloads.

So I'd like to suggest the following:

  1. First, look at the manifest in the repository (HEAD) and determine which version to download.
  2. Then, don't download the found manifest (manifest.json or manifest-beta.json), and instead, download manifest.json from the corresponding release, not from the repository content.
  • Alternatively, it will also make sense to download the manifest from the repository if manifest-beta.json is found so that pure-beta releases won't affect the stats.
  1. Download main.js and styles.css as well.

This way, the official download stats will reflect the number of downloads made via BRAT. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant