Inefficient guildInfo updating

[ahnl]

I guess it's because of getMessagesLeaderboard() function, which uses discordUtility.getUserById() function to translate user id to username. The latter function fetches 5 users (number of users displayed on the leaderboard) every 5 seconds (refresh rate) from Discord API seemingly without cache.

Needs investigating.

[ahnl]

A picture of how long an update takes and here's what it consists of:

    const messagesToday = await database.getMessageCount(mainServer)
    const memberCount = await discordUtility.getMemberCount(mainServer)
    const membersOnline = await discordUtility.getOnlineCount(mainServer)
    const config = await database.getDataCollectionConfig(mainServer)
    const boostStatus = await discordUtility.getBoostStatus(mainServer, config?.allowed ?? [])
    const codingLeaderboard = await getCodingLeaderboard()
    const messagesLeaderboard = await getMessagesLeaderboard()

[Esinko]

There should now be a cache for user date in getUserById. Could you run the test again?

[Chicken]

The code should probably also take advantage of parallel tasks with Promise.all() instead of doing these asynchronous tasks sequentially.

[Esinko]

A very good point.

[Esinko]

The code should probably also take advantage of parallel tasks with Promise.all() instead of doing these asynchronous tasks sequentially.

I implemented that here

[Esinko]

Should we consider this issue closed @ahnl?