Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.16.5: automake and gcc warnings #11

Open
kloczek opened this issue Apr 30, 2020 · 1 comment
Open

5.16.5: automake and gcc warnings #11

kloczek opened this issue Apr 30, 2020 · 1 comment

Comments

@kloczek
Copy link

kloczek commented Apr 30, 2020

automake warnings:

configure.ac:20: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and its use is discouraged.
configure.ac:20: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' macro instead,
configure.ac:20: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your Makefile.am files.
configure.ac:15: installing 'build-aux/compile'
configure.ac:9: installing 'build-aux/missing'
mission-control-plugins/Makefile.am:1: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
mission-control-plugins/Makefile.am: installing 'build-aux/depcomp'
plugins/Makefile.am:1: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
src/Makefile.am:1: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
src/Makefile.am:55: warning: source file '_gen/svc-Account_Interface_Conditions.c' is in a subdirectory,
src/Makefile.am:55: but option 'subdir-objects' is disabled
automake: warning: possible forward-incompatibility.
automake: At least a source file is in a subdirectory, but the 'subdir-objects'
automake: automake option hasn't been enabled.  For now, the corresponding output
automake: object file(s) will be placed in the top-level directory.  However,
automake: this behaviour will change in future Automake versions: they will
automake: unconditionally cause object files to be placed in the same subdirectory
automake: of the corresponding sources.
automake: You are advised to start using 'subdir-objects' option throughout your
automake: project, to avoid future incompatibilities.
src/Makefile.am:55: warning: source file '_gen/svc-Account_Interface_External_Password_Storage.c' is in a subdirectory,
src/Makefile.am:55: but option 'subdir-objects' is disabled
src/Makefile.am:55: warning: source file '_gen/svc-Account_Interface_Hidden.c' is in a subdirectory,
src/Makefile.am:55: but option 'subdir-objects' is disabled
src/Makefile.am:55: warning: source file '_gen/svc-Account_Manager_Interface_Hidden.c' is in a subdirectory,
src/Makefile.am:55: but option 'subdir-objects' is disabled
src/Makefile.am:55: warning: source file '_gen/svc-dispatcher.c' is in a subdirectory,
src/Makefile.am:55: but option 'subdir-objects' is disabled
tests/Makefile.am:1: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
tests/twisted/Makefile.am:228: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')

gcc 10 warnings:

mcd-operation.c: In function '_mcd_operation_dispose':
mcd-operation.c:145:34: warning: cast between incompatible function types from 'void (*)(McdMission *)' {aka 'void (*)(struct _McdMission *)'} to 'void (*)(void *, void *)' [-Wcast-function-type]
  145 |  g_list_foreach (priv->missions, (GFunc) _mcd_operation_child_unref,
      |                                  ^
mcd-operation.c: In function '_mcd_operation_connect':
mcd-operation.c:157:37: warning: cast between incompatible function types from 'void (*)(McdMission *)' {aka 'void (*)(struct _McdMission *)'} to 'void (*)(void *, void *)' [-Wcast-function-type]
  157 |     g_list_foreach (priv->missions, (GFunc) mcd_mission_connect, NULL);
      |                                     ^
mcd-operation.c: In function '_mcd_operation_disconnect':
mcd-operation.c:165:37: warning: cast between incompatible function types from 'void (*)(McdMission *)' {aka 'void (*)(struct _McdMission *)'} to 'void (*)(void *, void *)' [-Wcast-function-type]
  165 |     g_list_foreach (priv->missions, (GFunc) mcd_mission_disconnect, NULL);
      |                                     ^
mcd-client.c: In function 'mcd_client_proxy_free_client_filters':
mcd-client.c:1327:42: warning: cast between incompatible function types from 'void (*)(GHashTable *)' {aka 'void (*)(struct _GHashTable *)'} to 'void (*)(void *, void *)' [-Wcast-function-type]
 1327 |         g_list_foreach (*client_filters, (GFunc) g_hash_table_unref, NULL);
      |                                          ^
mcd-account-requests.c: In function '_mcd_account_create_request':
mcd-account-requests.c:164:28: warning: cast between incompatible function types from 'void (*)(void *)' to 'void (*)(void *, GClosure *)' {aka 'void (*)(void *, struct _GClosure *)'} [-Wcast-function-type]
  164 |                            (GClosureNotify) g_object_unref,
      |                            ^
mcd-account-requests.c:173:28: warning: cast between incompatible function types from 'void (*)(void *)' to 'void (*)(void *, GClosure *)' {aka 'void (*)(void *, struct _GClosure *)'} [-Wcast-function-type]
  173 |                            (GClosureNotify) g_object_unref,
      |                            ^
mcd-account-requests.c:179:28: warning: cast between incompatible function types from 'void (*)(void *)' to 'void (*)(void *, GClosure *)' {aka 'void (*)(void *, struct _GClosure *)'} [-Wcast-function-type]
  179 |                            (GClosureNotify) g_object_unref,
      |                            ^
mcd-manager.c: In function '_mcd_manager_disconnect':
mcd-manager.c:155:34: warning: cast between incompatible function types from 'void (*)(McdMission *)' {aka 'void (*)(struct _McdMission *)'} to 'void (*)(void *, void *)' [-Wcast-function-type]
  155 |     g_list_foreach (connections, (GFunc) mcd_mission_abort, NULL);
      |                                  ^
mcd-dispatcher.c: In function 'mcd_dispatcher_client_registry_ready_cb':
mcd-dispatcher.c:697:31: warning: cast between incompatible function types from 'void (*)(GValueArray *)' {aka 'void (*)(struct _GValueArray *)'} to 'void (*)(void *, void *)' [-Wcast-function-type]
  697 |     g_ptr_array_foreach (vas, (GFunc) g_value_array_free, NULL);
      |                               ^
mcd-dispatcher.c: In function 'mcd_dispatcher_update_client_caps':
mcd-dispatcher.c:788:31: warning: cast between incompatible function types from 'void (*)(GValueArray *)' {aka 'void (*)(struct _GValueArray *)'} to 'void (*)(void *, void *)' [-Wcast-function-type]
  788 |     g_ptr_array_foreach (vas, (GFunc) g_value_array_free, NULL);
      |                               ^
mcd-dispatcher.c: In function '_mcd_dispatcher_add_connection':
mcd-dispatcher.c:1534:35: warning: cast between incompatible function types from 'void (*)(GValueArray *)' {aka 'void (*)(struct _GValueArray *)'} to 'void (*)(void *, void *)' [-Wcast-function-type]
 1534 |         g_ptr_array_foreach (vas, (GFunc) g_value_array_free, NULL);
      |                                   ^
mcd-dispatcher.c: In function 'message_context_steal':
mcd-dispatcher.c:1559:13: warning: Deprecated pre-processor symbol, replace with
 1559 |     g_memmove (stolen, from, sizeof (MessageContext));
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mcd-dispatcher.c: In function 'channel_to_delegate_free':
mcd-dispatcher.c:1918:38: warning: cast between incompatible function types from 'void (*)(void *)' to 'void (*)(void *, void *)' [-Wcast-function-type]
 1918 |     g_queue_foreach (chan->handlers, (GFunc) g_object_unref, NULL);
      |                                      ^
mcd-connection.c: In function 'mcd_connection_early_get_interfaces_cb':
mcd-connection.c:1361:42: warning: cast between incompatible function types from 'void (*)(GValueArray *)' {aka 'void (*)(struct _GValueArray *)'} to 'void (*)(void *, void *)' [-Wcast-function-type]
 1361 |                                          (GFunc) g_value_array_free, NULL);
      |                                          ^
mcd-dispatch-operation.c: In function 'mcd_dispatch_operation_dispose':
mcd-dispatch-operation.c:1332:43: warning: cast between incompatible function types from 'void (*)(Approval *)' to 'void (*)(void *, void *)' [-Wcast-function-type]
 1332 |         g_queue_foreach (priv->approvals, (GFunc) approval_free, NULL);
      |                                           ^
mcd-account.c: In function 'mc_param_type':
mcd-account.c:2473:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
 2473 |         if (dbus_signature[1] == DBUS_TYPE_STRING)
      |            ^
mcd-account.c:2477:5: note: here
 2477 |     default:
      |     ^~~~~~~
account-store.c: In function 'main':
account-store.c:137:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
  137 |         if (argc >= 6)
      |            ^
account-store.c:140:7: note: here
  140 |       case OP_GET:
      |       ^~~~
In file included from value-is-same.c:27:
../src/mcd-account.c: In function 'mc_param_type':
../src/mcd-account.c:2473:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
 2473 |         if (dbus_signature[1] == DBUS_TYPE_STRING)
      |            ^
../src/mcd-account.c:2477:5: note: here
 2477 |     default:
      |     ^~~~~~~
@Kaffeine
Copy link
Member

I have no idea how to fix the cast between incompatible function types warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants