Merge pull request #98 from TechnologyEnhancedLearning/refactor-logging

Refactor logging

Author: Phil-NHS

CHANGELOG.md

@@ -1,62 +0,0 @@
-# [1.10.0](https://github.com/TechnologyEnhancedLearning/TELBlazor/compare/v1.9.1...v1.10.0) (2025-08-12)
-
-
-### Features
-
-* **pr readme:** we're due a version bump i feel ([f8d4314](https://github.com/TechnologyEnhancedLearning/TELBlazor/commit/f8d431497cfb5b659a2afdccd501774523a2127f))
-
-# [1.10.0-refactor-logging.1](https://github.com/TechnologyEnhancedLearning/TELBlazor/compare/v1.9.1...v1.10.0-refactor-logging.1) (2025-08-12)
-
-
-### Features
-
-* **pr readme:** we're due a version bump i feel ([f8d4314](https://github.com/TechnologyEnhancedLearning/TELBlazor/commit/f8d431497cfb5b659a2afdccd501774523a2127f))
-
-## [1.9.1](https://github.com/TechnologyEnhancedLearning/TELBlazor/compare/v1.9.0...v1.9.1) (2025-06-25)
-
-
-### Bug Fixes
-
-* **search:** Improved debounce ([fbc7b0b](https://github.com/TechnologyEnhancedLearning/TELBlazor/commit/fbc7b0be762982b8701c24e696133e0dd2facd97))
-
-# [1.9.0](https://github.com/TechnologyEnhancedLearning/TELBlazor/compare/v1.8.0...v1.9.0) (2025-06-25)
-
-
-### Features
-
-* **searchexperiment:** in theory ([fee2b91](https://github.com/TechnologyEnhancedLearning/TELBlazor/commit/fee2b9124b859f9a548e3fa257d53294ce83dc08))
-* **showcase:** added component readme displayer ([a058fe6](https://github.com/TechnologyEnhancedLearning/TELBlazor/commit/a058fe6f034b5097fb72c9f72a8b98c57ed2b607))
-
-# [1.9.0-feat-button-for-cicd-testing.1](https://github.com/TechnologyEnhancedLearning/TELBlazor/compare/v1.8.0...v1.9.0-feat-button-for-cicd-testing.1) (2025-06-25)
-
-
-### Bug Fixes
-
-* **search:** Improved debounce ([fbc7b0b](https://github.com/TechnologyEnhancedLearning/TELBlazor/commit/fbc7b0be762982b8701c24e696133e0dd2facd97))
-
-
-### Features
-
-* **searchexperiment:** in theory ([fee2b91](https://github.com/TechnologyEnhancedLearning/TELBlazor/commit/fee2b9124b859f9a548e3fa257d53294ce83dc08))
-* **showcase:** added component readme displayer ([a058fe6](https://github.com/TechnologyEnhancedLearning/TELBlazor/commit/a058fe6f034b5097fb72c9f72a8b98c57ed2b607))
-
-# [1.9.0-feat-button-for-cicd-testing.1](https://github.com/TechnologyEnhancedLearning/TELBlazor/compare/v1.8.0...v1.9.0-feat-button-for-cicd-testing.1) (2025-06-25)
-
-
-### Bug Fixes
-
-* **search:** Improved debounce ([fbc7b0b](https://github.com/TechnologyEnhancedLearning/TELBlazor/commit/fbc7b0be762982b8701c24e696133e0dd2facd97))
-
-
-### Features
-
-* **searchexperiment:** in theory ([fee2b91](https://github.com/TechnologyEnhancedLearning/TELBlazor/commit/fee2b9124b859f9a548e3fa257d53294ce83dc08))
-* **showcase:** added component readme displayer ([a058fe6](https://github.com/TechnologyEnhancedLearning/TELBlazor/commit/a058fe6f034b5097fb72c9f72a8b98c57ed2b607))
-
-# [1.9.0-feat-button-for-cicd-testing.1](https://github.com/TechnologyEnhancedLearning/TELBlazor/compare/v1.8.0...v1.9.0-feat-button-for-cicd-testing.1) (2025-06-25)
-
-
-### Features
-
-* **searchexperiment:** in theory ([fee2b91](https://github.com/TechnologyEnhancedLearning/TELBlazor/commit/fee2b9124b859f9a548e3fa257d53294ce83dc08))
-* **showcase:** added component readme displayer ([a058fe6](https://github.com/TechnologyEnhancedLearning/TELBlazor/commit/a058fe6f034b5097fb72c9f72a8b98c57ed2b607))

TELBlazor.Components/OptionalImplementations/Test/TestComponents/SearchExperiment/SearchExperimentServiceOpenApi.cs

@@ -14,7 +14,7 @@ namespace TELBlazor.Components.OptionalImplementations.Test.TestComponents.Searc
 {
     public class SearchExperimentServiceOpenApi :ISearchExperimentService
     {
-        //qqqq can do alot better
+        //qqqq very very much just bit of proof of concept.
         private readonly HttpClient _httpClient;
         private readonly string _baseUrl;
         private readonly ILogger<SearchExperimentServiceOpenApi> _logger; // logger

TELBlazor.Components/TELBlazor.Components.csproj

@@ -59,13 +59,12 @@
 			<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
 		</Content>
 	</ItemGroup>
-<!--qqqq tidy up and comment later-->
-		<!--Ensure no stale version cs files and that new ones are generated-->
-		<!--<Delete Files="TELBlazorPackageVersion/VersionInfo.TELBlazor.cs" />
-		<Delete Files="TELBlazorPackageVersion/VersionInfo.cs" />-->
 
+	<!--
+		Build partial classes for the version info. Compile version into before rest of the project so accessible for razor.
+	-->
 	<PropertyGroup>
-		<!-- Exclude generated files from auto-inclusion to prevent duplicates -->
+		<!-- Exclude generated files from auto-inclusion to prevent duplicates as we want to control order of compilation-->
 		<DefaultItemExcludes>$(DefaultItemExcludes);TELBlazorPackageVersion\VersionInfo.*.cs</DefaultItemExcludes>
 	</PropertyGroup>
 	<Target Name="PreBuildCleanup" BeforeTargets="GenerateTELBlazorPackageVersion;RunGulp;CoreCompile;BeforeCompile">
@@ -85,14 +84,10 @@ namespace TELBlazor.Components.TELBlazorPackageVersion
 			Overwrite="true"
 			Encoding="UTF-8" />
 	</Target>
-<!-- qqqq was this beforetargets corecompile -->
 	<Target Name="RunGulp" DependsOnTargets="GenerateTELBlazorPackageVersion" BeforeTargets="CoreCompile;BeforeCompile">
 		<Exec WorkingDirectory="$(MSBuildProjectDirectory)/.."
 			  Command="npx gulp --cwd &quot;$(MSBuildProjectDirectory)&quot; --gulpfile &quot;$(MSBuildProjectDirectory)/gulpfile.js&quot;" />
 	</Target>
-	
-	
-	<!--qqqq i dont think this should be needed-->
 	<Target Name="CompileVersionInfoBeforeRazor" DependsOnTargets="GenerateTELBlazorPackageVersion;RunGulp;PreBuildCleanup" BeforeTargets="CoreCompile;BeforeCompile">
 		<ItemGroup>
 			<Compile Include="TELBlazorPackageVersion\VersionInfo.TELBlazor.cs" />