Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Add mods to builds from add mod screen #596

Open
Ctrlaltdenied opened this issue Jul 9, 2016 · 9 comments
Open

[Suggestion] Add mods to builds from add mod screen #596

Ctrlaltdenied opened this issue Jul 9, 2016 · 9 comments

Comments

@Ctrlaltdenied
Copy link

Just a suggestion.

When adding a mod to the repo, an option at the end (tick boxes) to select which builds/modpacks you want to add the mod to. So you don't need to then manually go into the modpacks and add the mods.

@itsfolf
Copy link

itsfolf commented Jul 11, 2016

Since it'll need to be in the versions tab, there's no where to put it. Maybe a dropdown menu, but it will be a bit "ugly"

@skwerlman
Copy link
Contributor

I don't see how this would work, especially when dealing with multiple very old modpacks with hundreds of builds each.

@ctrlaltdeny
Copy link

if it was a drop down list it wouldn't be an issue. but I'm thinking of having an extra page to the form where it lists your builds and you just tick the ones you want to add the mod to and save it. with the typical select all and select none options.

@skwerlman
Copy link
Contributor

A dropdown or even tab with hundreds to thousands of entries is unusable. It'd get cluttered fast, and slow down the entire page.
Besides, this only really has utility when creating a new modpack. Once a pack is created, you really shouldn't be making changes to pre-existing builds, since they can only be obtained through a reinstall for users who already installed it.

@ctrlaltdeny
Copy link

who has thousands of builds exactly? I'm talking about from the add mod form an extra entry to add said mod directly to a build. when creating a new mod pack you select the mods from a drop down anyways. if I had 3 builds and wanted to add a mod, I'd tick all 3 boxes when doing so and wouldn't need to then go into each build and add them manually.

@skwerlman
Copy link
Contributor

I have at least two packs with >100 builds. I would not be surprised if i had >1000 builds in a couple years. Features should work for not only simple cases (3 builds), but also for extreme cases (>100 builds).
Besides, there's still the issue of editing existing builds. While possible, it is ALWAYS a bad idea, and this feature encourages it.

@ctrlaltdeny
Copy link

I didn't imagine folk would have a need for hundreds of builds. I have 3 public and 1 development build in the same mod pack. the only difference between the 3 builds is configured files. why would you possibly need that many builds?!

@skwerlman
Copy link
Contributor

People (including me) like to play on old versions of modpacks for various reasons. I make a point of never deleting old builds, so we end up with quite a few.

@itsfolf
Copy link

itsfolf commented Jul 12, 2016

On my old solder db I had a modpack with around 80 builds. Modpacks with a lot of builds aren't that rare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants