Stop UTF8 decoding/reencoding in Fortunes platform

Author: roji

frameworks/CSharp/aspnetcore/PlatformBenchmarks/BenchmarkApplication.Fortunes.cs

@@ -4,6 +4,7 @@
 #if DATABASE
 
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.IO.Pipelines;
 using System.Text.Encodings.Web;
 using System.Threading.Tasks;
@@ -43,7 +44,9 @@ private void OutputFortunes(PipeWriter pipeWriter, List<Fortune> model)
                 writer.Write(_fortunesRowStart);
                 writer.WriteNumeric((uint)item.Id);
                 writer.Write(_fortunesColumn);
-                writer.WriteUtf8String(HtmlEncoder.Encode(item.Message));
+                HtmlEncoder.EncodeUtf8(item.Message.AsSpan(), writer.Span, out var bytesConsumed, out var bytesWritten, isFinalBlock: true);
+                Debug.Assert(bytesConsumed == item.Message.Length, "Not enough remaining space in the buffer");
+                writer.Advance(bytesWritten);
                 writer.Write(_fortunesRowEnd);
             }
             writer.Write(_fortunesTableEnd);

frameworks/CSharp/aspnetcore/PlatformBenchmarks/BufferWriter.cs

@@ -44,7 +44,7 @@ public void Advance(int count)
     }
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public void Write(ReadOnlySpan<byte> source)
+    public void Write(scoped ReadOnlySpan<byte> source)
     {
         if (_span.Length >= source.Length)
         {
@@ -77,7 +77,7 @@ private void EnsureMore(int count = 0)
         _span = _output.GetSpan(count);
     }
 
-    private void WriteMultiBuffer(ReadOnlySpan<byte> source)
+    private void WriteMultiBuffer(scoped ReadOnlySpan<byte> source)
     {
         while (source.Length > 0)
         {

frameworks/CSharp/aspnetcore/PlatformBenchmarks/Data/Fortune.cs

@@ -5,18 +5,18 @@ namespace PlatformBenchmarks;
 
 public readonly struct Fortune : IComparable<Fortune>, IComparable
 {
-    public Fortune(int id, string message)
+    public Fortune(int id, byte[] message)
     {
         Id = id;
         Message = message;
     }
 
     public int Id { get; }
 
-    public string Message { get; }
+    public byte[] Message { get; }
 
     public int CompareTo(object obj) => throw new InvalidOperationException("The non-generic CompareTo should not be used");
 
     // Performance critical, using culture insensitive comparison
-    public int CompareTo(Fortune other) => string.CompareOrdinal(Message, other.Message);
+    public int CompareTo(Fortune other) => Message.AsSpan().SequenceCompareTo(other.Message.AsSpan());
 }

frameworks/CSharp/aspnetcore/PlatformBenchmarks/Data/Providers/RawDbNpgsql.cs

@@ -209,17 +209,19 @@ public async Task<List<Fortune>> LoadFortunesRows()
                     result.Add(new Fortune
                     (
                         id:rdr.GetInt32(0),
-                        message: rdr.GetString(1)
+                        message: rdr.GetFieldValue<byte[]>(1)
                     ));
                 }
             }
 
-            result.Add(new Fortune(id: 0, message: "Additional fortune added at request time." ));
+            result.Add(new Fortune(id: 0, AdditionalFortune));
             result.Sort();
 
             return result;
         }
 
+        private readonly byte[] AdditionalFortune = "Additional fortune added at request time."u8.ToArray();
+
         private (NpgsqlCommand readCmd, NpgsqlParameter<int> idParameter) CreateReadCommand(NpgsqlConnection connection)
         {
             var cmd = new NpgsqlCommand("SELECT id, randomnumber FROM world WHERE id = $1", connection);