Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download out-of-domain iframes #40

Open
kmike opened this issue Apr 19, 2016 · 3 comments
Open

download out-of-domain iframes #40

kmike opened this issue Apr 19, 2016 · 3 comments

Comments

@kmike
Copy link
Contributor

kmike commented Apr 19, 2016

When iframe is in a page it makes sense to get its content even if it is not in allowed domain. Maybe we shouldn't follow links in this case though.

@lopuhin
Copy link
Contributor

lopuhin commented Apr 20, 2016

Yeah, unless the iframe links point to the parent domain. I think ideally, the iframe should be included into the parent page contents in this case.

@kmike
Copy link
Contributor Author

kmike commented Apr 20, 2016

Yeah, I agree. There is QWebSettings::FrameFlatteningEnabled option (http://qutebrowser.org/tmp/qtdoc-linktitle/qwebsettings.html), maybe it could work for Splash. Alternatively, there is an API to go into iframes in QtWebKit (but not in upcoming QtWebEngine); is is already used by render.json endpoint, and we can create a Lua API for that if FrameFlatteningEnabled doesn't work.

@kmike
Copy link
Contributor Author

kmike commented Apr 20, 2016

Frame flattening option doesn't seem to work - I've tried it here scrapinghub/splash@8eb45d8, splash:html() doesn't include html content of iframes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants