Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: allow TValue to be specified in display and group column helpers #5667

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: allow TValue to be specified in display and group column helpers #5667

wants to merge 1 commit into from

Commits on Jul 18, 2024

  1. fix: allow TValue to be specified in display and group column helpers 

    Normally, this is not an issue, since ColumnDef is contravariant with respect to TValue. However, the user might extend BaseColumnDef or another constituent of ColumnDef such that ColumnDef becomes invariant with respect to TValue. In that case, DisplayColumnDef<TData, unknown> is no longer assignable to ColumnDef<TData, TValue>. By adding TValue as a generic argument to display and group helpers, Typescript can infer the required type of TValue.
    @ltreffenstaedtc24
    ltreffenstaedtc24 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    3eb37bd View commit details
    Browse the repository at this point in the history