Apply code review fixes and simplifications

- Fix: Unknown CLI commands now exit with code 1 instead of 0
- Fix: Catch block only handles ENOENT, re-throws other errors
- Fix: Add scripts field to package.json for monorepo consistency
- Refactor: Use early return pattern in listSkills for clarity
- Refactor: Replace nested ternary with helper function in docs

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: KyleAMathews

packages/skills/bin/cli.js

@@ -14,26 +14,28 @@ function listSkills(dir, prefix = '') {
     const itemPath = join(dir, item)
     const stat = statSync(itemPath)
 
-    if (stat.isDirectory()) {
-      const skillPath = join(itemPath, 'SKILL.md')
-      try {
-        const content = readFileSync(skillPath, 'utf-8')
-        const nameMatch = content.match(/^name:\s*(.+)$/m)
-        const descMatch = content.match(/description:\s*\|?\s*\n?\s*(.+)/m)
-
-        const name = nameMatch?.[1] || item
-        const desc = descMatch?.[1]?.trim() || 'No description'
-
-        console.log(`${prefix}${name}`)
-        console.log(`${prefix}  ${desc}`)
-        console.log()
-      } catch {
-        // No SKILL.md, check subdirectories
+    if (!stat.isDirectory()) continue
+
+    const skillPath = join(itemPath, 'SKILL.md')
+    try {
+      const content = readFileSync(skillPath, 'utf-8')
+      const nameMatch = content.match(/^name:\s*(.+)$/m)
+      const descMatch = content.match(/description:\s*\|?\s*\n?\s*(.+)/m)
+
+      const name = nameMatch?.[1] || item
+      const desc = descMatch?.[1]?.trim() || 'No description'
+
+      console.log(`${prefix}${name}`)
+      console.log(`${prefix}  ${desc}`)
+      console.log()
+    } catch (err) {
+      if (err.code !== 'ENOENT') {
+        throw err
       }
-
-      // Recurse into subdirectories
-      listSkills(itemPath, prefix + '  ')
+      // No SKILL.md, check subdirectories
     }
+
+    listSkills(itemPath, prefix + '  ')
   }
 }
 
@@ -89,7 +91,7 @@ switch (command) {
   case 'help':
   case '--help':
   case '-h':
-  default:
+  case undefined:
     console.log(`TanStack DB Skills CLI
 
 Usage:
@@ -104,4 +106,9 @@ Examples:
   db-skills show tanstack-db/mutations
 `)
     break
+
+  default:
+    console.error(`Unknown command: ${command}`)
+    console.log(`Run 'db-skills help' for usage information.`)
+    process.exit(1)
 }

packages/skills/package.json

@@ -31,5 +31,8 @@
   ],
   "engines": {
     "node": ">=18"
+  },
+  "scripts": {
+    "lint": "true"
   }
 }

packages/skills/skills/tanstack-db/live-queries/references/functional-variants.md

@@ -25,11 +25,16 @@ const { data } = useLiveQuery((q) =>
     id: row.user.id,
     displayName: `${row.user.firstName} ${row.user.lastName}`.trim(),
     emailDomain: row.user.email.split('@')[1],
-    ageGroup:
-      row.user.age < 25 ? 'young' : row.user.age < 50 ? 'adult' : 'senior',
+    ageGroup: getAgeGroup(row.user.age),
     isHighEarner: row.user.salary > 75000,
   })),
 )
+
+function getAgeGroup(age: number): 'young' | 'adult' | 'senior' {
+  if (age < 25) return 'young'
+  if (age < 50) return 'adult'
+  return 'senior'
+}
 ```
 
 ## fn.where
@@ -90,7 +95,7 @@ const { data } = useLiveQuery((q) =>
       },
       demographics: {
         age: user.age,
-        ageGroup: user.age < 25 ? 'young' : user.age < 50 ? 'adult' : 'senior',
+        ageGroup: getAgeGroup(user.age),
         isAdult: user.age >= 18,
       },
       profileStrength: calculateProfileStrength(user),
@@ -145,8 +150,7 @@ const { data } = useLiveQuery((q) =>
     (row): ProcessedUser => ({
       id: row.user.id,
       name: row.user.name,
-      ageGroup:
-        row.user.age < 25 ? 'young' : row.user.age < 50 ? 'adult' : 'senior',
+      ageGroup: getAgeGroup(row.user.age),
     }),
   ),
 )