Guidelines on Code Reviews

[mmislam101]

https://github.com/Tallwave/guidelines/blob/master/docs/Code.md

• What makes a good PR.
• PR process - branch names
• Gitflow
• Linting
• What to look for in reviewing.

*edited for clarity; the first 4 bullet points could be their own issues and are not directly a part of a Code Review

[krantzinator]

One thing we want to add:

• What are some common frameworks to use when looking at someone else's code that can encourage consistency?

Things to think on for this week:

• tech debt related things
• readability vs efficiency -- is there a balance

[vinnieking06]

• are variables clear? Will you know what they mean when you go back 2 months from now?
• Are you recreating functions that already exists? DRY!

[swilliams]

Be mindful of overdoing the DRY. Sometimes the simplest, most easily understandable way is to have duplication. Especially if it's only 2 of something.

[vinnieking06]

@swilliams good point! Learned that the hard way.