Block release_milestone, deposit, and refund on a Disputed contract via tests

[mikewheeleer]

Block release_milestone, deposit, and refund on a Disputed contract via tests

Description

raise_dispute transitions a contract to Disputed precisely to freeze releases until an arbiter resolves it. release_milestone in contracts/escrow/src/lib.rs requires status == Funded, so a release on a disputed contract should fail — but there is no explicit regression test asserting this, and refund_unreleased_milestones does allow Disputed, while deposit_funds requires Created. The exact behavior during a dispute is therefore implicit and unguarded.

This issue pins down, with tests, exactly which money-flow operations are blocked or allowed while a contract is Disputed.

Requirements and context

• Repository scope: Talenttrust/Talenttrust-Contracts only.
• Test: release_milestone on a Disputed contract panics with InvalidState.
• Test: deposit_funds on a Disputed contract panics with InvalidState.
• Test: refund_unreleased_milestones behavior on Disputed matches the documented intent (currently allowed).
• Document the disputed-state operation matrix.

Suggested execution

• Fork the repo and create a branch
• git checkout -b test/contracts-disputed-state-operations
• Implement changes
  • Write code in: no production change expected unless an inconsistency is found in contracts/escrow/src/lib.rs.
  • Write comprehensive tests in: contracts/escrow/src/test/dispute.rs.
  • Add documentation: add the disputed-state matrix under docs/escrow.
  • Include NatSpec-style doc comments (///) on any helper.
  • Validate security: no value moves to the freelancer mid-dispute.
• Test and commit

Test and commit

• Run cargo fmt --all -- --check, cargo build, and cargo test.
• Cover release, deposit, and refund against a disputed contract.
• Include the full cargo test output in the PR description.

Example commit message

test: pin money-flow operations blocked during dispute

Guidelines

• Minimum 95 percent test coverage for impacted modules.
• Clear, reviewer-focused documentation.
• Timeframe: 96 hours.

Community & contribution rewards

• 💬 Join the TalentTrust community on Discord for questions, reviews, and faster merges: https://discord.gg/WqnGpcPx
• ⭐ This is a GrantFox OSS / Official Campaign task and may be rewarded. When your PR is merged you'll be prompted to rate the project — if this issue and the maintainers helped you ship, we'd be grateful for a 5-star rating. Clear questions in Discord and tidy, well-tested PRs are the fastest path to a merge and a reward.

[Pascdav001]

@Pascdav001 has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

Hello boss, Please assign this issue to me. i checked it out and im confident i will solve it
my eta is 4 hours

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Pascdav001 to this issue.

[drips-wave]

Congratulations, @Pascdav001! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on June 30, 2026.

🧑‍💻 @Pascdav001: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊