Add tests for the dispute resolution_payouts split math in dispute.rs

[mikewheeleer]

Add tests for the dispute resolution_payouts split math in dispute.rs

Description

contracts/escrow/src/dispute.rs implements resolution_payouts for FullRefund, PartialRefund (70/30), FullPayout, and Split(client, freelancer), plus final_status_after_resolution. This pure money-splitting logic is the most security-sensitive code in the contract, yet it has no dedicated unit tests covering the 70/30 rounding, the Split total-must-equal-available rule, negative-split rejection, and the accounting-invariant guard.

This issue adds focused unit tests for the dispute payout calculations.

Requirements and context

• Repository scope: Talenttrust/Talenttrust-Contracts only.
• Test each DisputeResolution variant against a range of available balances, asserting (client_payout, freelancer_payout) and that the two always sum to available.
• Cover PartialRefund rounding at odd amounts (e.g. available = 7 → 30% truncation).
• Cover Split rejection when totals mismatch or amounts are negative (InvalidDisputeSplit).
• Cover the AccountingInvariantViolated path when available would be negative, and verify final_status_after_resolution returns Refunded only on full refund.

Suggested execution

• Fork the repo and create a branch
• git checkout -b test/contracts-dispute-payouts
• Implement changes
  • Write code in: contracts/escrow/src/dispute.rs — no logic change expected; only add a #[cfg(test)] module if needed.
  • Write comprehensive tests in: contracts/escrow/src/test/dispute.rs — table-driven assertions over all variants.
  • Add documentation: describe the payout matrix in docs/escrow/README.md.
  • Include NatSpec-style doc comments (///) where helpful.
  • Validate security assumptions: payouts conserve the available balance.
• Test and commit

Test and commit

• Run cargo fmt --all -- --check, cargo build, and cargo test.
• Cover edge cases: zero available, odd-amount PartialRefund, mismatched Split.
• Include full cargo test output in the PR description.

Example commit message

test: add resolution_payouts split-math coverage for dispute.rs

Guidelines

• Minimum 95 percent test coverage for impacted modules.
• Clear, reviewer-focused documentation.
• Timeframe: 96 hours.

Community & contribution rewards

• 💬 Join the TalentTrust community on Discord for questions, reviews, and faster merges: https://discord.gg/WqnGpcPx
• ⭐ This is a GrantFox OSS / Official Campaign task and may be rewarded. When your PR is merged you'll be prompted to rate the project — if this issue and the maintainers helped you ship, we'd be grateful for a 5-star rating. Clear questions in Discord and tidy, well-tested PRs are the fastest path to a merge and a reward.

[T-kesh]

@T-kesh has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

I would like to work on this

ℹ️ Repo Maintainers: To accept this application, review their application or assign @T-kesh to this issue.

[JemimahEkong]

Kindly assign this issue to me. I am confident that I camn implement the necessary fix. ETA: 24-48 hours

[DavisVT]

@DavisVT has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

pls assign me to this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @DavisVT to this issue.

[grantfox-oss]

🦊 GrantFox — @T-kesh has been assigned to this issue as part of the Official Campaign campaign!

Next steps:

1. Open a Pull Request referencing this issue (e.g., Closes #465)
2. Your PR will be reviewed by the Talenttrust maintainers

Good luck! Track your progress on GrantFox.