feat(datagrid): show whether a materialized view can be refreshed concurrently, and gate its structure edits by kind (#3063)

Author: datlechin

CHANGELOG.md

@@ -43,6 +43,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - **Extensions** for SQLite and local libSQL connections, loading sqlite-vec, SpatiaLite and other libraries on connect. (#2502)
 - Version history for saved queries, with **Restore This Version**. (#2505)
 - Git status letters, history and **Discard Changes…** for files in a linked SQL folder. (#2505)
+- Whether a materialized view can be refreshed concurrently, on its **Indexes** tab. (#2522)
 
 ### Changed
 
@@ -117,6 +118,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - **File > Import > Import Data…** importing every file as SQL. (#3047)
 - Saved query longer than 500,000 characters silently cut short when saved.
 - A file the import panel dimmed still opening, and reaching the wrong importer.
+- Materialized view opened from Open Quickly edited as a plain view. (#2522)
+- Index edits refused on a PGlite materialized view.
+- Structure grid and inspector taking edits the object or engine refuses, such as a materialized view's Type.
+- **Delete** and **Duplicate** in a structure row's menu doing nothing on an object that refuses them.
+- **New Trigger** offered on a materialized view.
 - Compressed dump named `.GZ` rather than `.gz` reaching the parser still compressed.
 - **SQL** offered as an import format on MongoDB.
 - **Save** permanently dim on a Custom provider for an OpenAI-compatible server that wants no API key.

TablePro/Core/Database/MaterializedViewRefreshing.swift

@@ -14,11 +14,12 @@ enum MaterializedViewRefreshing {
     /// Nil where the engine has no refresh that leaves readers alone, so the prompt offers no
     /// option at all rather than one that is always off.
     static func concurrentRefreshAvailability(
-        of target: DatabaseObjectTarget
+        of target: DatabaseObjectTarget,
+        provider: any ScopedMetadataProviding = DatabaseManager.shared
     ) async throws -> PluginConcurrentRefreshAvailability? {
         let name = target.name
         let schema = target.schema
-        return try await DatabaseManager.shared.withMetadataDriver(scope: target.scope) { driver in
+        return try await provider.withMetadataDriver(scope: target.scope) { driver in
             try await driver.concurrentRefreshAvailability(materializedView: name, schema: schema)
         }
     }

TablePro/Core/Plugins/PluginMetadataRegistry+CuratedDefaults.swift

@@ -590,7 +590,7 @@ extension PluginMetadataRegistry {
                 brandColorHex: "#F4B942",
                 queryLanguageName: "SQL", editorLanguage: .sql,
                 connectionMode: .network, supportsDatabaseSwitching: true,
-                structureEditing: SchemaEditingSupport(foreignKeyEdit: .alter),
+                structureEditing: SchemaEditingSupport(foreignKeyEdit: .alter, structureEdits: .postgreSQL),
                 capabilities: PluginMetadataSnapshot.CapabilityFlags(
                     supportsSchemaSwitching: true,
                     supportsImport: true,

TablePro/Core/Services/Infrastructure/LaunchIntent.swift

@@ -8,7 +8,14 @@ import TableProImport
 
 internal enum LaunchIntent: @unchecked Sendable {
     case openConnection(UUID)
-    case openTable(connectionId: UUID, database: String?, schema: String?, table: String, isView: Bool)
+    case openTable(
+        connectionId: UUID,
+        database: String?,
+        schema: String?,
+        table: String,
+        isView: Bool,
+        objectType: TableInfo.TableType? = nil
+    )
     case openQuery(connectionId: UUID, sql: String)
     /// Open a connection in Agent mode, optionally carrying the question the user already typed.
     case openAgentSession(connectionId: UUID, prompt: String?)
@@ -27,7 +34,7 @@ internal enum LaunchIntent: @unchecked Sendable {
     internal var targetConnectionId: UUID? {
         switch self {
         case .openConnection(let id),
-             .openTable(let id, _, _, _, _),
+             .openTable(let id, _, _, _, _, _),
              .openQuery(let id, _),
              .openAgentSession(let id, _):
             return id

TablePro/Core/Services/Infrastructure/LaunchIntentRouter.swift

@@ -109,7 +109,7 @@ internal final class LaunchIntentRouter {
         switch intent {
         case .openConnection(let id):
             return id
-        case .openTable(let id, _, _, _, _):
+        case .openTable(let id, _, _, _, _, _):
             return id
         case .openQuery(let id, _):
             return id

TablePro/Core/Services/Infrastructure/TabRouter.swift

@@ -61,10 +61,10 @@ internal final class TabRouter {
         case .openConnection(let id):
             try await openConnection(id: id)
 
-        case .openTable(let id, let database, let schema, let table, let isView):
+        case .openTable(let id, let database, let schema, let table, let isView, let objectType):
             try await openTable(
                 connectionId: id, transientConnection: nil,
-                database: database, schema: schema, table: table, isView: isView
+                database: database, schema: schema, table: table, isView: isView, objectType: objectType
             )
 
         case .openQuery(let id, let sql):
@@ -217,6 +217,7 @@ internal final class TabRouter {
     private func openTable(
         connectionId: UUID, transientConnection: DatabaseConnection? = nil,
         database: String?, schema: String?, table: String, isView: Bool,
+        objectType: TableInfo.TableType? = nil,
         passwordOverride: String? = nil, sshPasswordOverride: String? = nil
     ) async throws {
         let connection: DatabaseConnection
@@ -241,7 +242,8 @@ internal final class TabRouter {
             tableName: table,
             databaseName: database,
             schemaName: schema,
-            isView: isView
+            isView: isView,
+            objectType: objectType
         )
         DatabaseManager.shared.registerPendingSession(connection)
         WindowManager.shared.openTab(payload: payload)

TablePro/Models/Database/MaterializedViewConcurrentRefreshNote.swift

@@ -0,0 +1,45 @@
+//
+//  MaterializedViewConcurrentRefreshNote.swift
+//  TablePro
+//
+
+import Foundation
+import TableProPluginKit
+
+internal struct MaterializedViewConcurrentRefreshNote: Equatable {
+    internal let systemImage: String
+    internal let text: String
+
+    internal init?(state: MetadataLoadState<PluginConcurrentRefreshAvailability?>) {
+        switch state {
+        case .idle, .loading:
+            return nil
+        case .failed:
+            systemImage = "exclamationmark.triangle"
+            text = String(localized: "Couldn't check whether this view can be refreshed concurrently.")
+        case .loaded(let availability):
+            guard let availability else { return nil }
+            switch availability {
+            case .available:
+                systemImage = "checkmark.circle"
+                text = String(localized: "This view can be refreshed concurrently.")
+            case .requiresUniqueIndex:
+                systemImage = "info.circle"
+                text = String(
+                    localized: """
+                    Concurrent refresh needs a valid unique index on the view's columns, with no WHERE \
+                    clause and no expressions.
+                    """
+                )
+            case .requiresPopulatedView:
+                systemImage = "info.circle"
+                text = String(
+                    localized: "Concurrent refresh needs the view to be populated first. Refresh it once without that option."
+                )
+            @unknown default:
+                systemImage = "info.circle"
+                text = String(localized: "This view can't be refreshed concurrently.")
+            }
+        }
+    }
+}

TablePro/Models/Database/MaterializedViewRefreshPrompt.swift

@@ -73,7 +73,7 @@ internal struct MaterializedViewRefreshPrompt: Equatable {
         case .requiresUniqueIndex:
             return String(localized: "Needs a valid unique index on the view's columns, with no WHERE clause and no expressions.")
         case .requiresPopulatedView:
-            return String(localized: "Available once the view holds rows. Refresh it once without this option first.")
+            return String(localized: "Available once the view is populated. Refresh it once without this option first.")
         case .none:
             return ""
         @unknown default:

TablePro/Models/Database/StructureEditEligibility.swift

@@ -109,6 +109,17 @@ struct StructureObjectEditMatrix: Sendable, Equatable {
     ])
 }
 
+enum TriggerEditEligibility {
+    static func kindAcceptsTriggers(_ kind: TableInfo.TableType) -> Bool {
+        switch kind {
+        case .table, .partitionedTable, .view, .foreignTable:
+            return true
+        case .materializedView, .systemTable, .externalTable, .sequence:
+            return false
+        }
+    }
+}
+
 /// Whether the Structure tab may offer one edit right now, and what to say when it may not.
 ///
 /// Mirrors `ForeignKeyEditAvailability` so every refusal in this tab carries its own sentence. A

TablePro/Models/UI/InspectorRowSource.swift

@@ -14,12 +14,14 @@ internal struct InspectorRowField: Equatable {
     let value: String?
     let editor: FieldEditorKind
     let isModified: Bool
+    let isEditable: Bool
 
-    init(name: String, value: String?, editor: FieldEditorKind, isModified: Bool = false) {
+    init(name: String, value: String?, editor: FieldEditorKind, isModified: Bool = false, isEditable: Bool = true) {
         self.name = name
         self.value = value
         self.editor = editor
         self.isModified = isModified
+        self.isEditable = isEditable
     }
 }