fix(datagrid): open materialized views read-only in the data grid

Author: datlechin

CHANGELOG.md

@@ -60,6 +60,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Middle-dot separators dropped from the CSV inspector's status bar and the query history rows.
 - Connection marked with a tinted symbol rather than a color dot in the query history rows.
 - Safe Mode list offering only the levels a connection allows, with the reason under it and in the toolbar tooltip.
+- ClickHouse materialized views read-only in the data grid, as on every other engine.
 
 ### Removed
 
@@ -87,6 +88,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - **File > Import > Import Data…** importing every file as SQL. (#3047)
 - A file the import panel dimmed still opening, and reaching the wrong importer.
 - Materialized view opened from Open Quickly edited as a plain view. (#2522)
+- Materialized view rows editable in the data grid, then refused at Save.
 - Index edits refused on a PGlite materialized view.
 - Structure grid and inspector taking edits the object or engine refuses, such as a materialized view's Type.
 - **Delete** and **Duplicate** in a structure row's menu doing nothing on an object that refuses them.

TablePro/Core/Coordinators/RowEditingCoordinator.swift

@@ -42,9 +42,8 @@ final class RowEditingCoordinator: ObservableObject {
     // MARK: - Row Operations
 
     func addNewRow() {
-        guard !parent.safeModeLevel.blocksAllWrites,
+        guard parent.canEditActiveResult,
               let (tab, tabIndex) = parent.tabManager.selectedTabAndIndex,
-              tab.tableContext.isEditable,
               tab.tableContext.tableName != nil else { return }
 
         let tabId = tab.id
@@ -69,9 +68,8 @@ final class RowEditingCoordinator: ObservableObject {
     }
 
     func deleteSelectedRows(indices: Set<Int>) {
-        guard !parent.safeModeLevel.blocksAllWrites,
+        guard parent.canEditActiveResult,
               let (tab, tabIndex) = parent.tabManager.selectedTabAndIndex,
-              tab.tableContext.isEditable,
               !indices.isEmpty else { return }
 
         let tabId = tab.id
@@ -113,9 +111,8 @@ final class RowEditingCoordinator: ObservableObject {
     }
 
     func duplicateSelectedRow(index: Int) {
-        guard !parent.safeModeLevel.blocksAllWrites,
+        guard parent.canEditActiveResult,
               let (tab, tabIndex) = parent.tabManager.selectedTabAndIndex,
-              tab.tableContext.isEditable,
               tab.tableContext.tableName != nil else { return }
 
         let tabId = tab.id
@@ -337,7 +334,7 @@ final class RowEditingCoordinator: ObservableObject {
     }
 
     func pasteRows() {
-        guard !parent.safeModeLevel.blocksAllWrites,
+        guard parent.canEditActiveResult,
               let (tab, tabIndex) = parent.tabManager.selectedTabAndIndex,
               tab.tabType == .table else { return }
 

TablePro/Models/Database/StructureEditEligibility.swift

@@ -142,10 +142,9 @@ enum StructureEditAvailability: Sendable, Equatable {
 ///
 /// Pure, so the rule is testable without a connection, and ordered: an engine that cannot edit
 /// structure at all says that first, then the object's kind, then the engine's own statement for the
-/// operation. Reading the kind as one `isView` Bool is the defect this replaces, because
-/// `TableInfo.TableType.allowsRowEditing` is true for a materialized view, so the Structure tab
-/// offered `ADD COLUMN`, `SET NOT NULL`, type changes and constraint edits that PostgreSQL always
-/// refuses. (#2726)
+/// operation. Reading the kind as one `isView` Bool is the defect this replaces, because the Bool
+/// read false for a materialized view, so the Structure tab offered `ADD COLUMN`, `SET NOT NULL`,
+/// type changes and constraint edits that PostgreSQL always refuses. (#2726)
 enum StructureEditEligibility {
     static func allows(
         _ operation: StructureEditOperation,

TablePro/Models/Query/EditorTabPayload.swift

@@ -38,8 +38,7 @@ internal struct EditorTabPayload: Codable, Hashable {
     /// Whether this tab displays a database view (read-only)
     internal let isView: Bool
     /// The object's own kind, which decides which structure edits the tab may offer. Carried beside
-    /// `isView` because that Bool answers a different question and cannot tell a materialized view
-    /// from a table. (#2726)
+    /// `isView` because that Bool cannot say which of seven kinds the object is. (#2726)
     internal let objectType: TableInfo.TableType?
     /// Whether to show the structure view instead of data (for "Show Structure" context menu)
     internal let showStructure: Bool

TablePro/Models/Query/QueryResult.swift

@@ -170,9 +170,9 @@ struct TableInfo: Identifiable, Hashable, Sendable {
         /// that the server always refuses.
         var allowsRowEditing: Bool {
             switch self {
-            case .view, .externalTable, .sequence:
+            case .view, .materializedView, .externalTable, .sequence:
                 return false
-            case .table, .materializedView, .foreignTable, .systemTable, .partitionedTable:
+            case .table, .foreignTable, .systemTable, .partitionedTable:
                 return true
             }
         }

TablePro/Models/Query/QueryTabState.swift

@@ -574,11 +574,10 @@ struct TabTableContext: Equatable {
 
     /// The object's own kind, carried beside `isView` rather than replacing it.
     ///
-    /// The two answer different questions. `isView` decides whether the *rows* may be written, which
-    /// a dozen Bool-only carriers already speak (deeplinks, the URL parser, scripting, recents), and
-    /// it comes from `allowsRowEditing`, which is deliberately true for a materialized view because
-    /// a matview does hold rows. This says which of seven kinds the object is, which is the only
-    /// thing that can say which *structure* edits it accepts. Conflating them is the defect. (#2726)
+    /// `isView` is a read-only mark that a dozen Bool-only carriers already speak (deeplinks, the URL
+    /// parser, scripting, recents), and a tab saved by an older build can carry it false over a
+    /// materialized view. It cannot say which of seven kinds the object is. This can, and only the
+    /// kind says which *structure* edits the object accepts. (#2726)
     ///
     /// Nil on a tab restored from a file written before this existed, and on any path that never
     /// learned the kind; `resolvedObjectKind()` falls back to what `isView` can still tell us.
@@ -588,6 +587,10 @@ struct TabTableContext: Equatable {
         objectType ?? (isView ? .view : .table)
     }
 
+    var allowsRowEditing: Bool {
+        !isView && resolvedObjectKind().allowsRowEditing
+    }
+
     var primaryKeyColumn: String? { primaryKeyColumns.first }
 
     /// A tab opened without an explicit database carries an empty name and follows the window's

TablePro/Models/Schema/ForeignKeyEditSupport.swift

@@ -68,7 +68,7 @@ enum ForeignKeyEditPolicy {
     /// - Parameter kindRefusal: Why the object's own kind refuses a foreign key edit, nil when it
     ///   accepts one. Supplied by `StructureEditEligibility`, because only the per-kind matrix knows
     ///   which of seven object kinds is in front of the user. This used to be an `isTable` Bool
-    ///   derived from `allowsRowEditing`, which is true for a materialized view, so the "+" was
+    ///   derived from `allowsRowEditing`, which was true for a materialized view, so the "+" was
     ///   offered over an `ADD CONSTRAINT` PostgreSQL always refuses. (#2726)
     static func resolve(
         support: ForeignKeyEditSupport,

TablePro/Views/Main/Child/DataTabGridDelegate.swift

@@ -115,7 +115,7 @@ final class DataTabGridDelegate: DataGridViewDelegate {
     }
 
     func dataGridEmptySpaceMenu() -> NSMenu? {
-        guard let onAddRow else { return nil }
+        guard let onAddRow, coordinator?.canAddRow == true else { return nil }
         let menu = NSMenu()
         let target = StructureMenuTarget { onAddRow() }
         let item = NSMenuItem(

TablePro/Views/Main/Child/MainEditorContentView.swift

@@ -189,7 +189,6 @@ struct MainEditorContentView: View {
             updateHasQueryText()
             cachedChangeManager = AnyChangeManager(changeManager)
             wireDataTabDelegateStableRefs()
-            refreshDataTabDelegateMutableRefs()
             coordinator.dataTabDelegate = dataTabDelegate
         }
         .onDisappear {
@@ -204,36 +203,17 @@ struct MainEditorContentView: View {
         .onChange(of: selectionState.indices) { newIndices in
             onSelectionChange(newIndices)
         }
-        .onChange(of: tabManager.selectedTab?.tableContext.isEditable) { _ in
-            refreshDataTabDelegateMutableRefs()
-        }
-        .onChange(of: tabManager.selectedTab?.tableContext.isView) { _ in
-            refreshDataTabDelegateMutableRefs()
-        }
-        .onChange(of: tabManager.selectedTab?.tableContext.tableName) { _ in
-            refreshDataTabDelegateMutableRefs()
-        }
-        .onChange(of: coordinator.safeModeLevel) { _ in
-            refreshDataTabDelegateMutableRefs()
-        }
     }
 
     private func wireDataTabDelegateStableRefs() {
         dataTabDelegate.coordinator = coordinator
         dataTabDelegate.selectionState = selectionState
         dataTabDelegate.onCellEdit = onCellEdit
         dataTabDelegate.onSortStateChanged = onSortStateChanged
+        dataTabDelegate.onAddRow = onAddRow
         dataTabDelegate.onFilterColumn = onFilterColumn
     }
 
-    private func refreshDataTabDelegateMutableRefs() {
-        dataTabDelegate.onAddRow = currentTabAllowsAddRow ? onAddRow : nil
-    }
-
-    private var currentTabAllowsAddRow: Bool {
-        coordinator.canAddRow
-    }
-
     // MARK: - Tab Content
 
     @ViewBuilder

TablePro/Views/Main/Extensions/MainContentCoordinator+ResultEditing.swift

@@ -30,7 +30,7 @@ extension MainContentCoordinator {
     var canEditActiveResult: Bool {
         guard let tab = tabManager.selectedTab else { return false }
         return tab.tableContext.isEditable
-            && !tab.tableContext.isView
+            && tab.tableContext.allowsRowEditing
             && !safeModeLevel.blocksAllWrites
             && activeResultEditRefusal == nil
     }