Repository navigation
BackendUserHandler breaks workspace #535
Description
What are you trying to achieve?
A frontend request with enabled backend user.
As we extend admin panel and want to cover that with functional tests executing frontend requests.
What do you get instead?
We receive a 404 due to BackendUserHandler class which breaks the expected workspace aspect.
How to reproduce the issue?
Execute the following test:
$request = new InternalRequest();
$request = $request->withPageId(1);
$request = $request->withLanguageId($languageUid);
$requestContext = new InternalRequestContext();
$requestContext = $requestContext->withBackendUserId(1);
$html = (string) $this->executeFrontendSubRequest($request, $requestContext)->getBody();With the following database fixture:
<?php
declare(strict_types=1);
return [
'pages' => [
[
'uid' => 1,
'pid' => 0,
'title' => 'Page with uid 1 below 0',
'deleted' => 0,
'backend_layout' => 'pagets__21',
'slug' => '/start',
],
],
'be_users' => [
[
'uid' => 1,
'pid' => 0,
'tstamp' => 1366642540,
'username' => 'editor',
// The actual password is: password
'password' => '$1$tCrlLajZ$C0sikFQQ3SWaFAZ1Me0Z/1',
'admin' => 0,
'disable' => 0,
'starttime' => 0,
'endtime' => 0,
'options' => 0,
'crdate' => 1366642540,
'workspace_perms' => 1,
'deleted' => 0,
'TSconfig' => null,
'lastlogin' => 1371033743,
'workspace_id' => 0,
// Necessary to allow user to access this page.
'db_mountpoints' => 1,
// Necessary to open admin panel.
'uc' => serialize([
'AdminPanel' => [
'display_top' => true,
],
]),
],
],
];Additional information you would like to provide?
It looks like https://github.com/TYPO3/testing-framework/blob/8.0.8/Resources/Core/Functional/Extensions/json_response/Classes/Middleware/BackendUserHandler.php doesn't properly set the workspace property until one explicitly provides it within the test. Leading to keeping the -99 fallback which in turn will lead to other follow up issues as the system status is wrong.
That will lead to the expectation the user is in preview mode, which will trigger all kind of access checks for a public page.
Specify some data of the environment
- TYPO3 testing framework version: 8.0.8
- TYPO3 version: 12.4.10
- TYPO3 installation type: composer
- PHP version: 8.2.14
- Web server used + version: None
- Operating system: Ubuntu
Activity
DanielSiepmann commentedon Jan 25, 2024
Looks like falling back on
0if not provided would solve the issue.[BUGFIX] Do not end up in workspace and preview for default requests
DanielSiepmann commentedon Jan 25, 2024
Looks like the middleware misses some more proper initializations, e.g. UserTSconfig seems to be missing as well.
Looks like those two calls should be added as well:
And UC is also not unpacked … And the necessary method is now protected and therefore not available from the middleware.
sbuerk commentedon Jan 25, 2024
Can you provide a full testcase showing the issue ? (failing) - can be done as a WIP core patch.
TBH - not getting how parts are looking in the test setup not mentioned in the post/thread.
DanielSiepmann commentedon Jan 25, 2024
Sure, but will take some time as I moved forward and work on other areas right now …
[BUGFIX] Do not end up in workspace and preview for default requests
DanielSiepmann commentedon Jan 30, 2024
@sbuerk done: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82715 You can debug within
typo3/sysext/adminpanel/Classes/Utility/StateUtility.phpto see that the TSconfig is not provided, due to missing intialization. This is called from e.g.typo3/sysext/adminpanel/Classes/Middleware/AdminPanelInitiator.php.The provided PR fixes most of the issues for 12.4 and main.
But I couldn't find a way to unpack the uc of the user. That prevents to "open" the admin panel, the 2nd test.
DanielSiepmann commentedon Jan 30, 2024
Another proper solution might be to replace the provided middleware of testing framework with an authenticator which checks the provided request context and auths the user, allowing TYPO3 to work as usual? But I didn't give it a try yet.
[BUGFIX] Properly initialize backend user for requests
DanielSiepmann commentedon Feb 12, 2024
The given PR solves the issues and makes https://review.typo3.org/c/Packages/TYPO3.CMS/+/82715 pass.
[BUGFIX] Properly initialize backend user for requests
[BUGFIX] Properly initialize backend user for requests
[TASK] Add regression test for issue #395
[TASK] Add regression test for issue #395