Skip to content

Commit c02cd60

Browse files
committed
[BUGFIX] Fix UIDs for files depending on class implementing FileInterface
1 parent a2bd9a5 commit c02cd60

2 files changed

Lines changed: 10 additions & 8 deletions

File tree

Classes/Utility/FileUtility.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@
1919
use TYPO3\CMS\Core\Configuration\Features;
2020
use TYPO3\CMS\Core\Http\NormalizedParams;
2121
use TYPO3\CMS\Core\Imaging\ImageManipulation\CropVariantCollection;
22+
use TYPO3\CMS\Core\Resource\File;
2223
use TYPO3\CMS\Core\Resource\FileInterface;
24+
use TYPO3\CMS\Core\Resource\FileReference;
2325
use TYPO3\CMS\Core\Resource\ProcessedFile;
2426
use TYPO3\CMS\Core\Resource\Rendering\RendererRegistry;
2527
use TYPO3\CMS\Core\Utility\ArrayUtility;
@@ -65,8 +67,8 @@ public function process(FileInterface $fileReference, ProcessingConfiguration $p
6567
{
6668
$originalFileReference = clone $fileReference;
6769
$originalFileUrl = $fileReference->getPublicUrl();
68-
$fileReferenceUid = $fileReference->getUid();
69-
$uidLocal = $fileReference->getProperty('uid_local');
70+
$fileReferenceUid = $fileReference instanceof FileReference ? $fileReference->getUid() : null;
71+
$uidLocal = $fileReference instanceof File ? $fileReference->getUid() : $fileReference->getProperty('uid_local');
7072
$fileRenderer = $this->rendererRegistry->getRenderer($fileReference);
7173
$crop = $fileReference->getProperty('crop');
7274
$link = $fileReference->getProperty('link');

Tests/Unit/Utility/FileUtilityTest.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -212,8 +212,8 @@ public function testCustomProcessingOptions(): void
212212
'type' => 'image',
213213
'filename' => 'test-file.jpg',
214214
'originalUrl' => '/fileadmin/test-file.jpg',
215-
'uidLocal' => null,
216-
'fileReferenceUid' => 103,
215+
'uidLocal' => 103,
216+
'fileReferenceUid' => null,
217217
'size' => '71 KB',
218218
'dimensions' =>
219219
[
@@ -240,8 +240,8 @@ public function testCustomProcessingOptions(): void
240240
'link' => null,
241241
'mimeType' => 'image/jpeg',
242242
'type' => 'image',
243-
'uidLocal' => null,
244-
'fileReferenceUid' => 103,
243+
'uidLocal' => 103,
244+
'fileReferenceUid' => null,
245245
'size' => '71 KB',
246246
'dimensions' =>
247247
[
@@ -672,8 +672,8 @@ protected function getBaselineResultArrayForFile(): array
672672
'type' => 'image',
673673
'filename' => 'test-file.jpg',
674674
'originalUrl' => '/fileadmin/test-file.jpg',
675-
'uidLocal' => null,
676-
'fileReferenceUid' => 103,
675+
'uidLocal' => 103,
676+
'fileReferenceUid' => null,
677677
'size' => '71 KB',
678678
'dimensions' =>
679679
[

0 commit comments

Comments
 (0)