black catches format issues in jupyter notebooks?

[NimaSarajpoor]

So, I tried to run black stumpy/. and black tests/.. Both are okay!

However, when I run ./test.sh (or the custom test ./test.sh custom 1 ... , the black finds some formatting issues in jupyter notebooks and exit with error. The version of black in my environment is 22.6.0.

Could someone help me out regarding this matter? (@seanlaw)

[seanlaw]

That doesn't make sense. Can you provide your full ./test.sh custom 1 ... command?

I'm running the same version of black and didn't see anything when running ./setup.sh && test.sh.

[seanlaw]

I think it's because you have pip install 'black[jupyter]', which installed some dependencies that forces .ipynb files to get checked by black. In my case, I see:

Checking Black Code Formatting
Skipping .ipynb files as Jupyter dependencies are not installed.
You can fix this by running ``pip install black[jupyter]``
All done! ✨ 🍰 ✨
83 files would be left unchanged.

When I executed pip install black[jupyter] and then tried running black again, I see the same errors. I just added a fix to exclude .ipynb files in test.sh when executing black. Please merge the latest commits and see if that solves your problem.

[NimaSarajpoor]

I think it's because you have pip install 'black[jupyter]', which installed some dependencies that forces .ipynb files to get checked by black

Exactly! I actually did pip install 'black[jupyter] a few days ago. I got similar errors. However, when I did pip uninstall black and re-install it again, the issue was resolved (or maybe I did something else!).

But, this time, I couldn't resolve the issue! (And, I do not remember doing pip install 'black[jupyter]) I was wondering if pip uninstall black and re-installing it again would solve the issue. Did you try to uninstall the jupyter-related dependencies after executing pip install black[jupyter]?

---

Please merge the latest commits and see if that solves your problem.

Thanks! Will do so!

[NimaSarajpoor]

Please merge the latest commits and see if that solves your problem.

It works! Thanks.

[seanlaw]

Great!

[NimaSarajpoor]

@seanlaw
Should I accept this myself? Because, I cannot find the button "accept" or something like that in my end. So, please let me know if I should accept (close) this. Thanks :)