From 9eaf3df2f7194b5bf1af7f702867ace0aedcd096 Mon Sep 17 00:00:00 2001 From: DanRyanIrish Date: Tue, 19 Nov 2024 21:19:57 +0000 Subject: [PATCH 1/2] Make calibrated_visibilities store flare location at phase_center, rather than offset, in accordance with new xrayvision Visibilities object API. --- stixpy/calibration/visibility.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stixpy/calibration/visibility.py b/stixpy/calibration/visibility.py index f88dedf..fead240 100644 --- a/stixpy/calibration/visibility.py +++ b/stixpy/calibration/visibility.py @@ -442,11 +442,11 @@ def calibrate_visibility(vis: Visibilities, flare_location: SkyCoord = STIXImagi calibrated_visibility = (np.cos(calibrated_phase) + np.sin(calibrated_phase) * 1j) * calibrated_amplitude vis.meta["calibrated"] = True - vis.meta["offset"] = flare_location cal_vis = Visibilities( calibrated_visibility, u=vis.u, v=vis.v, + phase_center=flare_location, amplitude=calibrated_amplitude, amplitude_uncertainty=calibrated_amplitude_error, meta=vis.meta, From a054aa294932a5727f18b4d07f1222495f09da28 Mon Sep 17 00:00:00 2001 From: DanRyanIrish Date: Tue, 19 Nov 2024 21:30:50 +0000 Subject: [PATCH 2/2] Make default flare location s SkyCood in STIXImaging frame instead of STIXImaging frame itself. --- stixpy/calibration/visibility.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stixpy/calibration/visibility.py b/stixpy/calibration/visibility.py index fead240..8737833 100644 --- a/stixpy/calibration/visibility.py +++ b/stixpy/calibration/visibility.py @@ -385,7 +385,7 @@ def get_uv_points_data(d_det: u.Quantity[u.mm] = 47.78 * u.mm, d_sep: u.Quantity return uv_data -def calibrate_visibility(vis: Visibilities, flare_location: SkyCoord = STIXImaging(0 * u.arcsec, 0 * u.arcsec)): +def calibrate_visibility(vis: Visibilities, flare_location: SkyCoord = SkyCoord(Tx=0 * u.arcsec, Ty=0 * u.arcsec, frame=STIXImaging)): """ Calibrate visibility phase and amplitudes.