Some minor fixes #33
Merged
Some minor fixes #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix win32 compilation warning * Fix platform env
* Add link for Libretro cores on nightly.link
AShiningRay
approved these changes
Nov 7, 2024
| CXXFLAGS += -O0 -g | ||
| else | ||
| CFLAGS += -O3 |
There was a problem hiding this comment.
Didn't cause any issues over here, at least nothing that can be tested on a short time window. Usually i'd go for O2 instead since it is less aggressive and is considered safe enough for the Linux Kernel, but given that this is a project with a FAR smaller scope, O3 should be fine here going forward.
|
Well, other than the harmless observation above, i've nothing else to add. Solid Pull Request, merging as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.