Incorrect MMC5 emulation on QuickNES on Bizhawk 2.10.

[Grandmaster9918]

The cutscene where I meet Sypha in Castlevania III:

[Grandmaster9918]

What the cutscene should look like:

[nattthebear]

I seem to recall completely disabling QuickNES's MMC5 back in the day, as it wasn't very accurate. Has that regressed? This ROM should be running on NESHawk only.

[Grandmaster9918]

Any effort to improve MMC5 accuracy on QuickNES? You could look how FCEUX implemented it.

[YoshiRulz]

This is a regression like #4243 is then.

[CasualPokePlayer]

Indeed, looks like quickerNES is accepting MMC5, while our old code did not.

[nattthebear]

Any effort to improve MMC5 accuracy on QuickNES? You could look how FCEUX implemented it.

QuickNES on the whole is very fast and moderately accurate. It makes some compromises that are known to be wrong. The perfect, ideal NES emulator would use it as a reference in some places, but probably wouldn't use any code from it. FECUX isn't a great place to start either; we know a lot more now than we knew then (remember, FCEU's codebase is on the whole older than QuickNES), and a frankenstein of QuickNES and FCEUX is not going to hold a candle to Mesen.

If there's some question as to how MMC5 actually works, there are plenty of good references, like NesHawk. But I wouldn't recommend going further down this path. That's just my opinion though, and a bit of insight into why I just turned off MMC5 on this core 10 years ago. I'm sure there are improvements to be had, but in the wide, wide, world of NES emulation is getting this core to run this mapper that interesting?