Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when loading audio-only disc #4205

Open
YoshiRulz opened this issue Feb 2, 2025 · 0 comments
Open

Improve error message when loading audio-only disc #4205

YoshiRulz opened this issue Feb 2, 2025 · 0 comments
Labels
App: EmuHawk Relating to EmuHawk frontend Meta Relating to code organisation or to things that aren't code Request: Feature/Enhancement For feature requests or possible improvements

Comments

@YoshiRulz
Copy link
Member

Currently discards the DiscType, only writing game.System:

case DiscType.AudioDisc:
case DiscType.UnknownCDFS:
case DiscType.UnknownFormat:
game.System = _config.TryGetChosenSystemForFileExt(ext, out var sysID) ? sysID : VSystemID.Raw.NULL;
break;

So it ends up here:
if (cores.Count == 0) throw new InvalidOperationException("No core was found to try on the game");

@YoshiRulz YoshiRulz added App: EmuHawk Relating to EmuHawk frontend Meta Relating to code organisation or to things that aren't code Request: Feature/Enhancement For feature requests or possible improvements labels Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App: EmuHawk Relating to EmuHawk frontend Meta Relating to code organisation or to things that aren't code Request: Feature/Enhancement For feature requests or possible improvements
Projects
None yet
Development

No branches or pull requests

1 participant