Field with multiple dependencies

[alcohol]

I can't seem to get the following to work:

Form Foo with fields:

• A / a checkbox type input
• B / a choice type input
  • depends on A, if A is checked, B is not added

    ->addDependent('B', ['A'], function (DependentField $field, ?bool $checkbox): void {
      if ($checkbox) {
        return;
      }
      $field->add(ChoiceType::class, /* [...] */);
    }

• C / a text type input
  • depends on A, if A is checked, C is not added, depends on B, options change based on the value of B

    ->addDependent('C', ['A', 'B'], function (DependentField $field, ?bool $checkbox, ?string $choice): void {
      if ($checkbox) {
        return;
      }
      $field->add(TextType::class, /* [...] */);
    }

The above doesn't work though; if I check A, B disappears, but C is still added (or not removed 🤷).

[alcohol]

I guess this relates to #4 (comment) -- specifically, option B mentioned in this comment.

[toby-griffiths]

I have had a similar issue with a form for dietary requirements. I have the folllowing fields…

a. Do you have any dietrary requirements (yes/no)?
b. [only if a. = yes] Select your dietary requirement from a list of options;
c. [only if b. is not empty] Collection of fields asking…

• What is the reason (choice/intolerance/allergy)?

The problem I had… if I go from a form with…
a. yes;
b. something slected (so c. contains some reason fields for the selection);
c completed reason field(s);
… to…
a. no;
… then field b. disappears, but c. does not… BUT… only when I save the data. If I don't perform a save, field c. also, correctly, disapears. Done a whole load of step debugging, but still cannot fathom why this might be!?

My workaround was to add the following event listener to the form builder that adds the dynamic fields…

        ->addEventListener(FormEvents::PRE_SUBMIT, function (PreSubmitEvent $event) {
            $data = $event->getData();
            if (!($data['hasRequirements'] ?? false)) { // <= if a. is 'no'
                // First I tried this, to remove the collection of reasons, however the previously selected
                // reasons form still appears, just with empty values…
                $data['requirements'] = [];
                // So I also removed the child form all together…
                $event->getForm()->remove('requirements');
            }
            $event->setData($data);
        });

[toby-griffiths]

Anyone had any ideas on how we could improve the hadnling of nested dependencies? I've had this same issue again on another project this week.

Happy to submit a PR, but not sure the correct approach to take here.

[weaverryan]

Happy to submit a PR, but not sure the correct approach to take here.

that would be amazing!

Sa far as the approach, probably:

But when you're deep in there if you like a different solution, run with it!

// mainFood depends on meal & timeOfDay
$builder->addDependent('mainFood', ['meal', 'timeOfDay'], function(DependentField $field, string $meal) use ($data) {
        // ...
    });

I personally would not have any time to work on this. So community PR's to the rescue!

[ErwannDiagram]

Hello, I have a similar problem :

field A is changed => B succeeds to change but C does'nt.

It would be nice to set the priority/order of fields' updating :
My dumps reveal that the query of C, after a change of A, try to find values from B which is null at that moment (probably because of parallel queries)

[toby-griffiths]

Happy to submit a PR, but not sure the correct approach to take here.

that would be amazing!

Sa far as the approach, probably:

But when you're deep in there if you like a different solution, run with it!

// mainFood depends on meal & timeOfDay
$builder->addDependent('mainFood', ['meal', 'timeOfDay'], function(DependentField $field, string $meal) use ($data) {
// ...
});

I personally would not have any time to work on this. So community PR's to the rescue!

Thanks. I'll hopefully have a little time this or next week to look into this.

[devnix]

We are experiencing a similar problem: if we render an empty form with a dependency chain of A > B > C, marking A causes B to appear, and then marking B causes C to appear. If we unmark A, B, and C disappear.

But if we render the same form filled with A and B enabled, disabling A will hide B, but C will keep showing. Then enabling A again will show B and hide C

It may be a problem with the order of dependency checking, or should it process the whole dependency listeners until no more changes are being applied?

[devnix]

I've been able to vibe-code a solution (🤢), but before iterating on the solution, I wanted to create a failing test case.

Since the current test is not using live components or a real browser, I'm not able to create a reproducer. Maybe someone could help here with that?