DoctrineEntitySniff: do not require setter for property initialized in constructor

javer · javer · commit a8548a74cedb · 2023-03-22T15:19:05.000+02:00
diff --git a/Swivl/Sniffs/Commenting/DoctrineEntitySniff.php b/Swivl/Sniffs/Commenting/DoctrineEntitySniff.php
@@ -1566,6 +1566,7 @@ private function isPropertySetViaConstructor(string $name): bool
     {
         $members = $this->getInitializedMembers(false);
 
-        return isset($members[$name], $this->constructorParameters[$members[$name]]);
+        return isset($members[$name], $this->constructorParameters[$members[$name]])
+            || (isset($members[$name]) && $members[$name] !== 'null');
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -1566,6 +1566,7 @@ private function isPropertySetViaConstructor(string $name): bool`
`1566`	`1566`	`{`
`1567`	`1567`	`$members = $this->getInitializedMembers(false);`
`1568`	`1568`
`1569`		`- return isset($members[$name], $this->constructorParameters[$members[$name]]);`
	`1569`	`+ return isset($members[$name], $this->constructorParameters[$members[$name]])`
	`1570`	`+ \|\| (isset($members[$name]) && $members[$name] !== 'null');`
`1570`	`1571`	`}`
`1571`	`1572`	`}`