improve error messages and explicitly mention loggin in to anonymous users

Author: lorenzo-cavazzi

client/src/features/ProjectPageV2/ProjectPageContent/CodeRepositories/CodeRepositoryDisplay.tsx

@@ -53,6 +53,7 @@ import { CommandCopy } from "~/components/commandCopy/CommandCopy";
 import RenkuBadge from "~/components/renkuBadge/RenkuBadge";
 import RepositoryGitLabWarnBadge from "~/features/legacy/RepositoryGitLabWarnBadge";
 import { useGetRepositoriesQuery } from "~/features/repositories/api/repositories.api";
+import { useGetUserQueryState } from "~/features/usersV2/api/users.api";
 import { ABSOLUTE_ROUTES } from "~/routing/routes.constants";
 import { ButtonWithMenuV2 } from "../../../../components/buttons/Button";
 import { RtkOrNotebooksError } from "../../../../components/errors/RtkErrorAlert";
@@ -503,7 +504,7 @@ export function RepositoryPermissionsBadge({
     ? "Integration required"
     : !data?.metadata?.pull_permission &&
       data?.connection?.status === "connected"
-    ? "No access"
+    ? "Inaccessible"
     : !data?.metadata?.push_permission && !data?.provider?.id && hasWriteAccess
     ? "Request integration"
     : !data?.metadata?.push_permission && !data?.provider?.id && !hasWriteAccess
@@ -713,6 +714,15 @@ function RepositoryView({
   );
 }
 
+function LogInWarning() {
+  return (
+    <p className="mb-0">
+      You need to be logged in to activate integrations and access private
+      repositories.
+    </p>
+  );
+}
+
 interface RepositoryCallToActionAlertProps {
   hasWriteAccess: boolean;
   repositoryUrl: string;
@@ -726,6 +736,11 @@ export function RepositoryCallToActionAlert({
     url: repositoryUrl,
   });
 
+  const { data: userInfo } = useGetUserQueryState();
+  const anonymousUser = useMemo(() => {
+    return userInfo && !userInfo?.isLoggedIn;
+  }, [userInfo]);
+
   const search = useMemo(() => {
     return `?${new URLSearchParams({
       targetProvider: data?.provider?.id ?? "",
@@ -750,50 +765,64 @@ export function RepositoryCallToActionAlert({
               Either the repository does not exist, or you do not have access to
               it.
             </p>
-            <p className="mb-2">
-              If you think you should have access, check your integration{" "}
-              <span className="fst-italic">{data.provider.name}</span>.
-            </p>
-            <Link
-              className={cx("btn", "btn-primary", "btn-sm")}
-              to={{
-                pathname: ABSOLUTE_ROUTES.v2.integrations,
-                search,
-              }}
-            >
-              <Plugin className={cx("bi", "me-1")} />
-              View integration
-            </Link>
+            {anonymousUser ? (
+              <LogInWarning />
+            ) : (
+              <>
+                <p className="mb-2">
+                  If you think you should have access, check your integration{" "}
+                  <span className="fst-italic">{data.provider.name}</span>.
+                </p>
+                <Link
+                  className={cx("btn", "btn-primary", "btn-sm")}
+                  to={{
+                    pathname: ABSOLUTE_ROUTES.v2.integrations,
+                    search,
+                  }}
+                >
+                  <Plugin className={cx("bi", "me-1")} />
+                  View integration
+                </Link>
+              </>
+            )}
           </>
         ) : (
           <>
-            <p>
+            <p className={cx(!hasWriteAccess && "mb-0")}>
               The repository URL is invalid or points to a version control
-              platform we currently do not support. Please verify the URL and
-              check if the platform is in the currently supported{" "}
-              <Link
-                to={{
-                  pathname: ABSOLUTE_ROUTES.v2.integrations,
-                  search,
-                }}
-              >
-                <Plugin className={cx("bi", "me-1")} />
-                integrations list.
-              </Link>
+              platform we currently do not support.
+              {hasWriteAccess && (
+                <>
+                  {" "}
+                  Please verify the URL and check if the platform is in the
+                  currently supported{" "}
+                  <Link
+                    to={{
+                      pathname: ABSOLUTE_ROUTES.v2.integrations,
+                      search,
+                    }}
+                  >
+                    <Plugin className={cx("bi", "me-1")} />
+                    integrations list.
+                  </Link>
+                </>
+              )}
             </p>
 
-            <p className="mb-0">
-              If you&apos;re certain the URL is correct,{" "}
-              <a
-                target="_blank"
-                rel="noreferrer noopener"
-                href="mailto:[email protected]"
-              >
-                <Send className={cx("bi", "me-1")} />
-                contact us
-              </a>{" "}
-              about adding an integration.
-            </p>
+            {hasWriteAccess && (
+              <p className="mb-0">
+                If you&apos;re certain the URL is correct,{" "}
+                <a
+                  target="_blank"
+                  rel="noreferrer noopener"
+                  href="mailto:[email protected]"
+                >
+                  <Send className={cx("bi", "me-1")} />
+                  contact us
+                </a>{" "}
+                about adding an integration.
+              </p>
+            )}
           </>
         )}
       </ErrorAlert>
@@ -882,16 +911,20 @@ export function RepositoryCallToActionAlert({
           permissions, you can log in through the integration{" "}
           <span className="fst-italic">{data.provider.name}</span>.
         </p>
-        <Link
-          className={cx("btn", "btn-primary", "btn-sm")}
-          to={{
-            pathname: ABSOLUTE_ROUTES.v2.integrations,
-            search,
-          }}
-        >
-          <Plugin className={cx("bi", "me-1")} />
-          View integration
-        </Link>
+        {anonymousUser ? (
+          <LogInWarning />
+        ) : (
+          <Link
+            className={cx("btn", "btn-primary", "btn-sm")}
+            to={{
+              pathname: ABSOLUTE_ROUTES.v2.integrations,
+              search,
+            }}
+          >
+            <Plugin className={cx("bi", "me-1")} />
+            View integration
+          </Link>
+        )}
       </InfoAlert>
     );
   }