Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard token naming convention #1

Open
2 of 3 tasks
xgreenx opened this issue Jun 7, 2021 · 1 comment
Open
2 of 3 tasks

Standard token naming convention #1

xgreenx opened this issue Jun 7, 2021 · 1 comment
Assignees
Labels
blocker It means that issue is blocker for production

Comments

@xgreenx
Copy link
Contributor

xgreenx commented Jun 7, 2021

At the moment the library implements the next standard tokens: ERC20, ERC721, ERC1155.

But naming Erc* is related to the Ethereum network. In the case of Polkadot, we need to define our own specifications.
For specification, we can use PSP repository. Like naming, we can use PSP20 and etc. But maybe someone has better ideas about the naming of tokens.

!ink and Rust have unique features so we also need to think about the optimal function and their signature.
For example, we can include decrease_allowance and increase_allowance to Erc20 implementation like standard functions.

This is is blocker because the naming of traits influences the generation process of selectors for functions. So changing naming of traits later will break cross-contract execution of deployed contracts.

Proposals status:

@xgreenx xgreenx self-assigned this Jun 7, 2021
@xgreenx xgreenx added the blocker It means that issue is blocker for production label Jun 7, 2021
@xgreenx
Copy link
Contributor Author

xgreenx commented Jul 2, 2021

We created a proposal to define traits for fungible tokens.
When the proposal will be approved we will adopt the implementation and will create proposals for ERC721 and ERC1155.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker It means that issue is blocker for production
Projects
None yet
Development

No branches or pull requests

1 participant