Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track deprecations #1

Open
0xdabbad00 opened this issue Jun 11, 2019 · 6 comments
Open

Track deprecations #1

0xdabbad00 opened this issue Jun 11, 2019 · 6 comments

Comments

@0xdabbad00
Copy link
Contributor

When AWS deprecates a policy they aren't listed anymore. I don't keep track of this. I should. An example is ServiceQuotasServiceRolePolicy no longer exists.

@0xdabbad00
Copy link
Contributor Author

I'm seeking feedback if anyone has ideas on how I should deprecate these. Currently, the following polices in this repo do not exist anymore if you call aws iam list-policies:

  • AmazonMachineLearningRoleforRedshiftDataSource
  • ServiceQuotasServiceRolePolicy
  • TagGovernancePolicy

Should I delete these policies? Rename them with -deprecated? Change the contents with a custom flag, like deprecated: True?

@z0ph
Copy link

z0ph commented Jun 12, 2019

-deprecated sounds a good idea ;)

Does this repository is fully automated? how does this work under the hood?

@0xdabbad00
Copy link
Contributor Author

I manually run the commands a few times per day. Usually once in the morning, afternoon, and evening. It's on my todo list to automate it.

@RyPeck
Copy link

RyPeck commented Aug 30, 2019

The AWSOpsWorksRegisterCLI policy appears to be deprecated now.

@RyPeck
Copy link

RyPeck commented Sep 5, 2019

Should I delete these policies? Rename them with -deprecated? Change the contents with a custom flag, like deprecated: True?

Don't delete and don't change the contents is my gut reaction. -deprecated OR moving them to a policies-deprecated path. Having it in a different path makes it more obvious for users.

@0xdabbad00
Copy link
Contributor Author

I like that idea @RyPeck of having another directory for the deprecated policies. It makes it easier to search only on the the active policies too. I'll either manually find and move the policies over or look at what the options are for #3 to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants