Skip to content
This repository was archived by the owner on Apr 22, 2024. It is now read-only.

Commit 10576db

Browse files
author
joshmccloskey
committed
Updating colors for dark theme
Bug: 133277663 Test: Verified colors are correct for dark & light themes. Change-Id: If1aa5f22286d15918cfec3cd4a6436760bf304b2
1 parent 03c47e7 commit 10576db

File tree

4 files changed

+35
-1
lines changed

4 files changed

+35
-1
lines changed

color-check-baseline.xml

+32
Original file line numberDiff line numberDiff line change
@@ -3037,4 +3037,36 @@
30373037
column="5"/>
30383038
</issue>
30393039

3040+
<issue
3041+
id="HardCodedColor"
3042+
severity="Error"
3043+
message="Avoid using hardcoded color"
3044+
category="Correctness"
3045+
priority="4"
3046+
summary="Using hardcoded color"
3047+
explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
3048+
errorLine1=" &lt;color name=&quot;face_intro_outline&quot;>#ffdadce0&lt;/color> &lt;/color>"
3049+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
3050+
<location
3051+
file="res/values/colors.xml"
3052+
line="150"
3053+
column="40"/>
3054+
</issue>
3055+
3056+
<issue
3057+
id="HardCodedColor"
3058+
severity="Error"
3059+
message="Avoid using hardcoded color"
3060+
category="Correctness"
3061+
priority="4"
3062+
summary="Using hardcoded color"
3063+
explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
3064+
errorLine1=" android:fillColor=&quot;@color/face_intro_outline&quot;"
3065+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
3066+
<location
3067+
file="res/drawable/face_enroll_introduction.xml"
3068+
line="25"
3069+
column="40"/>
3070+
</issue>
3071+
30403072
</issues>

res/drawable/face_enroll_introduction.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
android:viewportHeight="300">
2323

2424
<path
25-
android:fillColor="#DADCE0"
25+
android:fillColor="@color/face_intro_outline"
2626
android:fillType="evenOdd"
2727
android:pathData="M150,0C67.16,0,0,67.16,0,150s67.16,150,150,150 s150-67.16,150-150S232.84,0,150,0 M150,4c39,0,75.66,15.19,103.24,42.76C280.81,74.34,296,111,296,150s-15.19,75.66-42.76,103.24 C225.66,280.81,189,296,150,296s-75.66-15.19-103.24-42.76C19.19,225.66,4,189,4,150S19.19,74.34,46.76,46.76 C74.34,19.19,111,4,150,4" />
2828
<path

res/values-night/colors.xml

+1
Original file line numberDiff line numberDiff line change
@@ -27,5 +27,6 @@
2727
<color name="notification_importance_selection_bg">@*android:color/material_grey_800</color>
2828
<color name="notification_importance_button_selected">#AECBFA</color> <!-- material blue 200 -->
2929
<color name="notification_importance_button_unselected">#5F6368</color>
30+
<color name="face_intro_outline">?android:attr/colorAccent</color>
3031
</resources>
3132

res/values/colors.xml

+1
Original file line numberDiff line numberDiff line change
@@ -147,4 +147,5 @@
147147
<!-- Dialog background color -->
148148
<color name="dialog_background">@*android:color/background_device_default_light</color>
149149

150+
<color name="face_intro_outline">#ffdadce0</color>
150151
</resources>

0 commit comments

Comments
 (0)