Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky blank string children #17

Open
Jeddf opened this issue Jan 18, 2018 · 1 comment
Open

Sticky blank string children #17

Jeddf opened this issue Jan 18, 2018 · 1 comment

Comments

@Jeddf
Copy link
Member

Jeddf commented Jan 18, 2018

When making and then deleting a space after a word, an empty string element is appended on as a child of the contenteditable div.

These elements build up and only seem to be able to be destroyed if the whole div is destroyed, they even stick around after a submit event. This means they can build up indefinitely over time, not seen any performance hit in practice as yet but it seems like something that should be dealt with.

sticky-elements

@wesleytodd
Copy link
Contributor

I think this is actually related to the other one, the formatting function has a bit of funky behavior with multiple spaces. I would look at fixing the handling of that. Might be a good one to add unit tests for since you could probably mimic this all just by calling that method directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants