remove the git submodule

[haoel]

Hi

I notice this project includes another project (github.com/dgrijalva) by using git submodule.

However, this raises an error while using go get with -u options, it reports vendor/github.com/dgrijalva/jwt-go/.git exists but is not a directory

$go get -u -v github.com/StephanDollberg/go-json-rest-middleware-jwt

package github.com/StephanDollberg/go-json-rest-middleware-jwt/vendor/github.com/dgrijalva/jwt-go: /home/ubuntu/go/src/github.com/StephanDollberg/go-json-rest-middleware-jwt/vendor/github.com/dgrijalva/jwt-go/.git exists but is not a directory

Actually this is a go-lang's issue: golang/go#17522 (golang haven't fixed this yet)

The main reason to open this issue is that I think it's better to use standardized golang package management rather than git submodule.

Thanks,
Hao

[StephanDollberg]

Hello @haoel ,

I didn't know they broke submodules again. They don't seem to like them.

I want to keep the vendor in as otherwise people will just not know what to do and move away. I am however fine with dropping submodules and vendoring the code directly. If you would like to get a PR ready for that, I am more than happy to review&merge.

Thanks,
Stephan

[haoel]

Hi @StephanDollberg

I have a questions, if we moved the submodule, the go get would help to download the vendor automatically because of package dependency, right? If it is, then this should be transparent to the people. And if we just put the code directly, we have to update the code manually, this is not good.

Regards,
Hao

[StephanDollberg]

Not sure I fully understand what you mean.

go get should also already fetch the code, it's just broken. We also have to update the submodule if we want to update the code.

The only difference would be that we copy the whole vendored code directly into the repo instead of using submodules.

[haoel]

sorry for late response.

I think, maybe we can use standard package dependency management way to manage the dependency instead of we manually do that.