Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vector3Extensions/Vector2Extensions kinda CodeReview #100

Open
soraphis opened this issue Aug 12, 2022 · 0 comments
Open

Vector3Extensions/Vector2Extensions kinda CodeReview #100

soraphis opened this issue Aug 12, 2022 · 0 comments

Comments

@soraphis
Copy link

soraphis commented Aug 12, 2022 •
edited
Loading

https://github.com/StansAssets/com.stansassets.foundation/blob/master/Runtime/Extensions/UnityEngine/Vector3Extensions.cs#L16-L22

this is the same as: return (b - a).sqrMagnitude (https://docs.unity3d.com/ScriptReference/Vector3-sqrMagnitude.html)

https://github.com/StansAssets/com.stansassets.foundation/blob/master/Runtime/Extensions/UnityEngine/Vector3Extensions.cs#L30-L36

this is the same as return a * s (https://docs.unity3d.com/ScriptReference/Vector3-operator_multiply.html)

https://github.com/StansAssets/com.stansassets.foundation/blob/master/Runtime/Extensions/UnityEngine/Vector3Extensions.cs#L44-L51

this is the same as return Vector3.Sacle(a, b) (https://docs.unity3d.com/ScriptReference/Vector3.Scale.html)

same things apply for Vector2Extensions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@soraphis