Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pot Decorations Component Doesn't Accept Valid Empty List #1742

Closed
RoarkCats opened this issue Feb 2, 2025 · 3 comments
Closed

Pot Decorations Component Doesn't Accept Valid Empty List #1742

RoarkCats opened this issue Feb 2, 2025 · 3 comments
Labels
🐛 bug Something isn't working 📄 vanilla-mcdoc

Comments

@RoarkCats
Copy link

The pot_decorations component is allowed to be empty in item predicates, however, it errors when this is the case

This advancement trigger works as expected, passing when the component is empty/just "brick" and failing when any sherds have been used

Image

   "criteria": {
        "requirement": {
            "trigger": "minecraft:placed_block",
            "conditions": {
                "location": [
                    {
                        "condition": "minecraft:match_tool",
                        "predicate": {
                            "items": "minecraft:decorated_pot",
                            "components": {
                                    "minecraft:pot_decorations": []
                            }
                        }
                    }
                ]
            }
        }
    }
@RoarkCats
Copy link
Author

Another example of the error working

Image

Image

            "components": {
                "minecraft:pot_decorations": [
                    "minecraft:scrape_pottery_sherd",
                    "minecraft:sheaf_pottery_sherd"
                ]
            }

@RoarkCats
Copy link
Author

Sister issue: misode/misode.github.io#690

@misode
Copy link
Member

misode commented Feb 6, 2025

Fixed in SpyglassMC/vanilla-mcdoc@19cd26c

@misode misode closed this as completed Feb 6, 2025
@misode misode added 🐛 bug Something isn't working 📄 vanilla-mcdoc labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 📄 vanilla-mcdoc
Projects
None yet
Development

No branches or pull requests

2 participants