Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If-None-Match does not work when W/ prefix is used or when quoted #1722

Closed
misode opened this issue Jan 19, 2025 · 1 comment
Closed

If-None-Match does not work when W/ prefix is used or when quoted #1722

misode opened this issue Jan 19, 2025 · 1 comment
Assignees
@SPGoding
Labels
🐛 bug Something isn't working /web-api-server

Comments

@misode
Copy link
Member

misode commented Jan 19, 2025

I expected that I would be able to pass the received ETag header value directly into If-None-Match, and this is also described on MDN. However it only returns a 304 when you send the hash itself.

Image
Image

Side note: Maybe double check whether User-Agent validation is working, because I think these requests worked without me setting a user agent.
@misode misode added /web-api-server 🐛 bug Something isn't working labels Jan 19, 2025
@misode misode changed the title If-None-Match does not work when W/ prefix is used If-None-Match does not work when W/ prefix is used or when quoted Jan 19, 2025
@SPGoding
Copy link
Member

SPGoding commented Jan 19, 2025 •
edited
Loading

This was fixed in 721276b. The User-Agent check should be working; I think the tool you use might have a default user agent? I see requests with User-Agent: yaak in the log on the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SPGoding SPGoding

Labels
🐛 bug Something isn't working /web-api-server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SPGoding @misode