forked from github/rubocop-github
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathrails_view_render_literal.rb
64 lines (53 loc) · 1.57 KB
/
rails_view_render_literal.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
# frozen_string_literal: true
require "rubocop"
module RuboCop
module Cop
module GitHub
class RailsViewRenderLiteral < Cop
MSG = "render must be used with a string literal"
def_node_matcher :literal?, <<-PATTERN
({str sym true false nil?} ...)
PATTERN
def_node_matcher :render?, <<-PATTERN
(send nil? :render $...)
PATTERN
def_node_matcher :render_literal?, <<-PATTERN
(send nil? :render ({str sym} $_) $...)
PATTERN
def_node_matcher :render_with_options?, <<-PATTERN
(send nil? :render (hash $...) ...)
PATTERN
def_node_matcher :ignore_key?, <<-PATTERN
(pair (sym {
:inline
}) $_)
PATTERN
def_node_matcher :partial_key?, <<-PATTERN
(pair (sym {
:file
:layout
:partial
}) $_)
PATTERN
def on_send(node)
return unless render?(node)
if render_literal?(node)
elsif option_pairs = render_with_options?(node)
if option_pairs.any? { |pair| ignore_key?(pair) }
return
end
if partial_node = option_pairs.map { |pair| partial_key?(pair) }.compact.first
if !literal?(partial_node)
add_offense(node, location: :expression)
end
else
add_offense(node, location: :expression)
end
else
add_offense(node, location: :expression)
end
end
end
end
end
end