Raise an error when Help Scout does something the gem does not support

Author: dennispaagman

lib/help_scout.rb

@@ -3,6 +3,7 @@
 
 class HelpScout
   class ValidationError < StandardError; end
+  class NotImplementedError < StandardError; end
 
   HTTP_CREATED = 201
   HTTP_BAD_REQUEST = 400
@@ -30,6 +31,8 @@ def create_conversation(data)
     elsif last_response.code == HTTP_BAD_REQUEST
       # Validation failed so return the errors
       raise ValidationError, last_response.parsed_response["message"]
+    else
+      raise NotImplementedError, "Help Scout returned something that is not implemented by the help_scout gem yet. Sorry."
     end
   end
 

spec/helpscout_spec.rb

@@ -36,6 +36,20 @@
         expect { client.create_conversation(data) }.to raise_error(HelpScout::ValidationError, "Email is not valid")
       end
     end
+
+    context 'with a not implemented status code' do
+      it 'returns a not implemented error' do
+        data = { subject: "Help me!" }
+
+        url = 'https://api.helpscout.net/v1/conversations.json'
+        stub_request(:post, url).
+          to_return(
+            status: 500,
+          )
+
+        expect { client.create_conversation(data) }.to raise_error(HelpScout::NotImplementedError)
+      end
+    end
   end
 
   describe '#search_conversations' do