Master Branch Does not Build

[andrewkrug]

I tried building the project in stable rust and nightly rust. Each time I receive the following error.

   Compiling rusoto_credential v0.11.0
warning[E0122]: trait bounds are not (yet) enforced in type definitions
   --> /Users/akrug/.cargo/registry/src/github.com-1ecc6299db9ec823/rusoto_credential-0.11.0/src/lib.rs:290:1
    |
290 | / pub type AutoRefreshingProviderSync<P: ProvideAwsCredentials + 'static> =
291 | |     BaseAutoRefreshingProvider<P, Mutex<Shared<P::Future>>>;
    | |____________________________________________________________^

warning[E0122]: trait bounds are not (yet) enforced in type definitions
   --> /Users/akrug/.cargo/registry/src/github.com-1ecc6299db9ec823/rusoto_credential-0.11.0/src/lib.rs:318:1
    |
318 | / pub type AutoRefreshingProvider<P: ProvideAwsCredentials + 'static> =
319 | |     BaseAutoRefreshingProvider<P, RefCell<Shared<P::Future>>>;
    | |______________________________________________________________^

error[E0599]: no method named `to_ascii_lowercase` found for type `std::string::String` in the current scope
   --> /Users/akrug/.cargo/registry/src/github.com-1ecc6299db9ec823/rusoto_credential-0.11.0/src/profile.rs:215:46
    |
215 |         let lower_case_line = unwrapped_line.to_ascii_lowercase().to_string();
    |                                              ^^^^^^^^^^^^^^^^^^
    |
    = help: items from traits can only be used if the trait is in scope
    = note: the following trait is implemented but not in scope, perhaps add a `use` for it:
            candidate #1: `use std::ascii::AsciiExt;`

error: aborting due to previous error

error: Could not compile `rusoto_credential`.

To learn more, run the command again with --verbose.

[econmang]

Hello Andrew, sorry to hear about that. We noted that you are using rusoto_credential v. 0.11.0 and we had our build dependencies at v. 0.8.0 so we are rolling up to see if that potentially helps. Using rustup update to update to newest version of nightly to see if I can recreate the error. I'll get back to you as quick as I can.

[econmang]

Hey Andrew, I'm having some trouble recreating the error on my end. I'm current running with rustc 1.28.0-nightly, but also pulled and ran the program on an older desktop of mine which I had installed rustc 1.26.0-nightly and was able to pull and build there as well.

After some review, though, we think that it was probably due to a difference in our build dependencies. As, rusoto_credential seems to have a big update regarding the trait bounds; you can review the issue described here, as well as the update here. I've linked to the 'changed files' section of the update, as it seems to address the specific lines discussed in the error above, the largest seems to be the removal of the static lifetime parameter.

We've updated the .toml to build with v. 0.11.0 of rusoto_credential in hopes that that will alleviate the issue. Could you please try to pull and build again?

[andrewkrug]

Still having issues building.

error[E0597]: borrowed value does not live long enough
    --> /Users/akrug/.cargo/registry/src/github.com-1ecc6299db9ec823/unicode-normalization-0.1.7/src/tables.rs:7532:30
     |
7532 |         '\u{1F247}' => Some(&['\u{3014}', '\u{52DD}', '\u{3015}']),
     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- temporary value only lives until here
     |                              |
     |                              does not live long enough
     |
     = note: borrowed value must be valid for the static lifetime...

[econmang]

Hey Andrew,

Would you mind telling me your rustc version? It would appear that unicode-normalization is utilized by some of our dependencies. I did a search through the unicode-normalization and found a recent issue (here) that seems to state that it now requires a minimum rustc version of 1.21.0.

I was able to recreate your errors error[E0122] and error[E0597] by rolling back to rustc versions nightly-2017-08-31 and nightly-2017-04-27, respectively.