Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATM10 Server Crashing #4165

Open
ZhrJosh opened this issue Jan 19, 2025 · 3 comments
Open

ATM10 Server Crashing #4165

ZhrJosh opened this issue Jan 19, 2025 · 3 comments
Labels
platform: neoforge Affects SpongeNeo status: investigation Marks an issue as needing investigation, usually for specific block of code or logic status: wip Work in progress type: bug Something isn't working version: 1.21.1 API 12 (LTS)

Comments

@ZhrJosh
Copy link

ZhrJosh commented Jan 19, 2025

Affected Product(s)

SpongeForge

Version

SpongeNeo 1.21.1-21.1.35-12.0.0-RC2002

Operating System

Windows 11

Java Version

1.21.1

Plugins/Mods

https://www.curseforge.com/minecraft/modpacks/all-the-mods-10/relations/dependencies

Describe the bug

When I run ATM10 without Sponge it works perfectly fine, but when I add SpongeNeo it crashes with the following console error:

[14:00:46.198] [main/ERROR] [loading.moddiscovery.ModFile/LOADING]: Access transformer file META-INF/accesstransformer.cfg provided by mod allthewizardgear does not exist!
Exception in thread “main” java.lang.module.FindException: Module org.yaml.snakeyaml not found, required by space.arim.dazzleconf.ext.snakeyaml
at java.base/java.lang.module.Resolver.findFail(Resolver.java:892)
at java.base/java.lang.module.Resolver.resolve(Resolver.java:192)
at java.base/java.lang.module.Resolver.resolve(Resolver.java:141)
at java.base/java.lang.module.Configuration.resolveAndBind(Configuration.java:491)
at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.ModuleLayerHandler.buildLayer(ModuleLayerHandler.java:75)
at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.ModuleLayerHandler.buildLayer(ModuleLayerHandler.java:87)
at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.Launcher.run(Launcher.java:90)
at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.Launcher.main(Launcher.java:74)
at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26)
at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23)
at [email protected]/cpw.mods.bootstraplauncher.BootstrapLauncher.run(BootstrapLauncher.java:210)
at [email protected]/cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:69)

I also attached the full log file if needed.

Link to logs

https://pastebin.com/1RY2DDSz

@ZhrJosh ZhrJosh added status: needs triage This label is automatically applied to new issues and pull requests to indicate they require triage type: bug Something isn't working labels Jan 19, 2025
gabizou added a commit that referenced this issue Jan 20, 2025
In a part of working on #4165, there's several redirects and general
incompatibilities that Sponge can introduce with other mods. Notably
out of the box, there's Observable, which aims to provide per-chunk
based observability of things that are occurring. It is not confirmed
this alone is enough to make it work.
@gabizou
Copy link
Member

gabizou commented Jan 20, 2025

So one incompatibility:

  • Spark has a new bug report that it's mistakenly shipping service manifests that JPMS won't allow us to change Refer to [neo] Sponge redistributes adventure services declarations lucko/spark#485 However, the fix for this can be as simple as using
  • Observable - the hooks we have in both are not feasible unless both Sponge and Observable switch to use WrapOperation to be compatible with each other (because if Sponge uses WrapOperation, Observable will replace Sponge's tracking system points, which kinda defeats the purpose of plugins being able to list to events as the world changes.
    • Pending this PR's verification that it's compatible fully, we'd likely need some more time on this one
  • Placebo this is harder to make changes with as it involves Placebo's changing a line, or us at Sponge making further changes to keep events between the two platforms in sync (since Plugins can listen to events, we try to keep SpongeAPI events sync'ed with Mod events so Mod event listeners also get any further changes suggested from plugins).
    • Being that this is a "core" library mod, the longer list
FastWorkbench-1.21-9.1.2.jar
irons_jewelry-1.21.1-1.0.4.jar
GatewaysToEternity-1.21.1-5.0.2.jar
moreoverlays-1.23.2-mc1.21-neoforge.jar
Apotheosis-1.21.1-8.1.2.jar
HostileNeuralNetworks-1.21.1-6.1.3.jar
servercore-neoforge-1.5.5+1.21.1.jar
ApothicAttributes-1.21.1-2.6.1.jar
PackMenu-1.21-7.0.2.jar
ApothicSpawners-1.21.1-1.2.0.jar
Placebo-1.21.1-9.6.4.jar
FastFurnace-1.21.1-9.0.0.jar
WitherSkeletonTweaks-1.21.1-10.0.2.jar
  • There's an additional compatibility that I've not been able to trace down with some mod that is doing something with registries that results in an awkward error like
[17:18:55] [main/ERROR] [minecraft/Main]: Failed to start the minecraft server
net.neoforged.fml.ModLoadingException: Loading errors encountered:
	- An uncaught parallel processing error has occurred.
	  java.lang.NullPointerException: Trying to access unbound value: ResourceKey[minecraft:block / evilcraft:gem_stone_torch]

	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.ModLoader.waitForFuture(ModLoader.java:281) ~[loader-4.0.35.jar%2360!/:4.0] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.ModLoader.waitForTask(ModLoader.java:183) ~[loader-4.0.35.jar%2360!/:4.0] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.ModLoader.runInitTask(ModLoader.java:163) ~[loader-4.0.35.jar%2360!/:4.0] {}
	at TRANSFORMER/[email protected]/net.neoforged.neoforge.internal.CommonModLoader.begin(CommonModLoader.java:51) ~[neoforge-21.1.97-universal.jar%23511!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.neoforged.neoforge.server.loading.ServerModLoader.load(ServerModLoader.java:34) ~[neoforge-21.1.97-universal.jar%23511!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.server.Main.main(Main.java:124) ~[server-1.21.1-20240808.144430-srg.jar%23510!/:?] {re:mixin,re:classloading,pl:mixin:A}
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) ~[?:?] {}
	at java.base/java.lang.reflect.Method.invoke(Method.java:580) ~[?:?] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.CommonLaunchHandler.runTarget(CommonLaunchHandler.java:136) ~[loader-4.0.35.jar%2360!/:4.0] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.CommonLaunchHandler.serverService(CommonLaunchHandler.java:128) ~[loader-4.0.35.jar%2360!/:4.0] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.CommonServerLaunchHandler.runService(CommonServerLaunchHandler.java:32) ~[loader-4.0.35.jar%2360!/:4.0] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.CommonLaunchHandler.lambda$launchService$4(CommonLaunchHandler.java:118) ~[loader-4.0.35.jar%2360!/:4.0] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:30) [modlauncher-11.0.4.jar%2362!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) [modlauncher-11.0.4.jar%2362!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) [modlauncher-11.0.4.jar%2362!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.Launcher.run(Launcher.java:103) [modlauncher-11.0.4.jar%2362!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.Launcher.main(Launcher.java:74) [modlauncher-11.0.4.jar%2362!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) [modlauncher-11.0.4.jar%2362!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) [modlauncher-11.0.4.jar%2362!/:?] {}
	at [email protected]/cpw.mods.bootstraplauncher.BootstrapLauncher.run(BootstrapLauncher.java:210) [bootstraplauncher-2.0.2.jar:?] {}
	at [email protected]/cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:69) [bootstraplauncher-2.0.2.jar:?] {}
  • Servercore-neoforge This one is going to be an incompatibility based on our usage of Configurate and Snakeyaml, which we ship as 1.x and servercore requires snakeyaml 2. This won't be easy to fix as we won't be able to update that until later. This I think will be permanently incompatible.

@gabizou gabizou added status: wip Work in progress version: 1.21.1 API 12 (LTS) status: investigation Marks an issue as needing investigation, usually for specific block of code or logic platform: neoforge Affects SpongeNeo and removed status: needs triage This label is automatically applied to new issues and pull requests to indicate they require triage labels Jan 20, 2025
@gabizou
Copy link
Member

gabizou commented Jan 20, 2025

Just giving an update:

  • Placebo 9.6.5 has the commit that fixes compatibility
  • SpongeNeo 1.21.1-21.1.35-12.0.1-RC2013 has some compatibility fixes as mentioned above, with observability apparently "functioning".

There is still a startup issue that I'm tracing down that's still not resolved in the modpack.

@Yeregorix
Copy link
Member

About the snakeyaml issue:
servercore ships snakeyaml 2.2
sponge ships snakeyaml 1.28
This is likely what cause the error.

A temporary workaround is to remove the snakeyaml entry in sponge-libraries.json in the sponge jar.

A proper fix might be to update snakeyaml to a newer version in sponge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: neoforge Affects SpongeNeo status: investigation Marks an issue as needing investigation, usually for specific block of code or logic status: wip Work in progress type: bug Something isn't working version: 1.21.1 API 12 (LTS)
Projects
None yet
Development

No branches or pull requests

3 participants