Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Node Version #76

Open
tvthatsme opened this issue Sep 19, 2023 · 2 comments
Open

Update Node Version #76

tvthatsme opened this issue Sep 19, 2023 · 2 comments

Comments

@tvthatsme
Copy link
Contributor

Getting warnings when using this action

The following actions uses node12 which is deprecated and will be forced to run on node16: SpeedCurve-Metrics/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Would you consider accepting a Pull Request to update the node version?
@josephwynn-sc
Copy link
Member

Hey @tvthatsme, that would be awesome - thank you!

@tvthatsme tvthatsme mentioned this issue Sep 20, 2023
Merged
@tvthatsme
Copy link
Contributor Author

tvthatsme commented Sep 20, 2023 •
edited
Loading

@josephwynn-sc mind taking a look at #77? I think this should do it. Local testing passes but I could be making assumptions for how GH actually runs it on Node 20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tvthatsme @josephwynn-sc